Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

component definition custom properties as dictionary #616

Merged
merged 17 commits into from
Apr 3, 2024

Conversation

mizrael
Copy link
Contributor

@mizrael mizrael commented Apr 3, 2024

Updated the implementation of custom properties on component definitions to use a dictionary instead of an array.
This allows the serializer to output YAML in this form:

Component: 
Name: Component1
CustomProperties:
  MyFuncProp1:
    Direction: Input
    Parameters:
      param1:
        DataType: String
        IsRequired: true

instead of

Component: 
Name: Component1
CustomProperties:
- Name: MyFuncProp1
  Direction: Input
  PropertyType: Function
  DataType: String
  Category: Data
  IsResettable: false
  Default: lorem
  Parameters:
  - Name: param1

@mizrael mizrael requested review from a team as code owners April 3, 2024 02:19
src/Persistence/Models/CustomProperty.cs Outdated Show resolved Hide resolved
@mizrael mizrael merged commit 48f274f into master Apr 3, 2024
4 checks passed
@mizrael mizrael deleted the users/davgui/component-custom-properties branch April 3, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants