WellKnownTemplateIds and AddPowerAppsPersistence refactoring
#638
Conversation
|
|
||
| namespace Microsoft.PowerPlatform.PowerApps.Persistence.Templates; | ||
|
|
||
| public static class WellKnownTemplateIds |
There was a problem hiding this comment.
@petrochuk has added something similar in https://github.com/microsoft/PowerApps-Tooling/pull/636/files#diff-ac4572e52bc9a7f059eddb37ee233946299b268991310aaf4caefd7c1484ad22 . I'd wait for his PR to go in first and then adapt the changes.
There was a problem hiding this comment.
I think it makes more sense to have names and ids in one place instead of having two separate classes: one for names and one for ids
There was a problem hiding this comment.
This class only hods IDs. the names are extra metadata which are out of scope of document template Ids.
I've remerged with master and used these constants in your 'BuiltInTemplates' class so there's still a single source of truth.
There was a problem hiding this comment.
I think it would be useful to have ids in the same place as names
joem-msft
force-pushed
the
users/joemay/Persistence-misc
branch
from
31a3254
to
ce383d1
Compare
- accepts additional parameter for configuring template store. - removed parameter `useDefaultTemplates` in preference for tests to make explicit call to utility method or to do other custom logic. - Renamed `AddDefaultTemplates` to `TESTING_ONLY_AddDefaultTemplates` to be clear about intention of usage. - `WellKnownTemplateIds` constants for id's used in the persistence assembly. Updated ServiceCollectionExtensions to use these. - Update AppGenerator to use ProjectReferences
joem-msft
force-pushed
the
users/joemay/Persistence-misc
branch
from
ce383d1
to
e08274c
Compare
|
|
||
| namespace Microsoft.PowerPlatform.PowerApps.Persistence.Templates; | ||
|
|
||
| public static class WellKnownTemplateIds |
There was a problem hiding this comment.
I think it would be useful to have ids in the same place as names
WellKnownTemplateIdsconstants for id's used in the persistence assembly. Updated ServiceCollectionExtensions to use these.AddPowerAppsPersistencemodified:useDefaultTemplatesin preference for tests to make explicit call to utility method or to do other custom logic.AddDefaultTemplatestoTESTING_ONLY_AddDefaultTemplatesto be clear about intention of usage. Made it public so it can be called by DocServer test code directly.ControlTemplateto indicate whether it's a Component or Pcf control template (UpdateControlTemplateto indicate whether it's a Component or Pcf control template #631)"