Reorganize .editorconfig (no changes to rule severities) #640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petrochuk
reviewed
Apr 17, 2024
mizrael
reviewed
Apr 17, 2024
mizrael
approved these changes
Apr 17, 2024
This commit contains no actual changes to the rules; it's only a reordering of the different types of configuration settings. - Add comments to some rule codes to make them readable - Moved all styling, naming, convention rules first. Some IDEs have been known to only support the top-most .editorconfig file to have these - All rule severity configurations are grouped by kind: - .net styles - C# styles - Code-style Diagnostic Rules - Code Quality Diagnostic Rules - Style Cop Analyzer Diagnostic Rules
…n by rule to work correctly.
joem-msft
force-pushed
the
users/joemay/reorganize-editorconfig
branch
from
520091d
to
8dcfc46
Compare
tehcrashxor
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
.editorconfig rules config line orderings have caused certiain rules to get skipped.
Solution
Changed the ordering in the editorconfig so settings are grouped and rule severities come after styling rules.
I then fixed existing code that did not comply with the rules.
Changes
Reorganize .editorconfig (no changes to rule severities)
This commit contains no actual changes to the rules; it's only a reordering of the different types of configuration settings.
Validation
Addressed build failures and fixed unit tests.