PaYaml schema and OM updates #651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petrochuk
reviewed
May 8, 2024
joem-msft
force-pushed
the
users/joemay/PaYaml-next
branch
2 times, most recently
from
fe4540d
to
205aed2
Compare
petrochuk
previously requested changes
May 8, 2024
tehcrashxor
approved these changes
May 8, 2024
joem-msft
force-pushed
the
users/joemay/PaYaml-next
branch
3 times, most recently
from
b3c2c8f
to
6952e03
Compare
Schema Updates: - Changed schema version from 2.2 to 3.0 - Update to use Control Type Identifiers in schema - Added `Groups` on Screens, ControlInstances, ComponentDefinitions per XR - Added `CodeComponent` contorl instances, aka PCF controls, per XR - Added VSCode snippets for App, Screens, and ControlInstances - Removed `App.Children.Host` from schema; it needs additional design review Model Updates: - Update ordering of PaFileRoot properties - Rename `ControlInstance.ControlType` to `ControlTypeId` to keep consistency - Add tests which verify when full usage of schema is used that round-trip is not lossy - Added support for `Groups` on Screens, ControlInstances, ComponentDefinitions per XR - Added extension method `DescendantControlInstances` for iterating thru control tree in document order - Added unit tests for `DescendantControlInstances` - Remove `AppInstance.Children` as the current design is not sufficient - Renamed `PersistenceException` to `PersistenceLibraryException` to remove naming ambiguity when in doc svr code Also: - Added build script that will process schema files. It removes comments and also enables some build-time modifications to the schema for public consumption.
joem-msft
force-pushed
the
users/joemay/PaYaml-next
branch
from
6952e03
to
e388ff8
Compare
tehcrashxor
approved these changes
May 15, 2024
mizrael
reviewed
May 15, 2024
mizrael
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update schema and OM according to latest changes
Schema Updates:
Groupson Screens, ControlInstances, ComponentDefinitions per XRCodeComponentcontorl instances, aka PCF controls, per XRApp.Children.Hostfrom schema; it needs additional design reviewModel Updates:
ControlInstance.ControlTypetoControlTypeIdto keep consistencyGroupson Screens, ControlInstances, ComponentDefinitions per XRDescendantControlInstancesfor iterating thru control tree in document orderDescendantControlInstancesAppInstance.Childrenas the current design is not sufficientPersistenceExceptiontoPaPersistenceExceptionto remove naming ambiguity when in doc svr codeAlso: