Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed "Pa" prefix where it is not necessary #654

Merged
merged 2 commits into from
May 16, 2024

Conversation

petrochuk
Copy link
Contributor

@petrochuk petrochuk commented May 16, 2024

This PR solves issue of "Pa" repeating three times. Microsoft.PowerPlatform.PowerApps.Persistence.PaYaml.Serialization.PaYamlSerializer

@petrochuk petrochuk requested review from a team as code owners May 16, 2024 02:37
@petrochuk petrochuk enabled auto-merge (squash) May 16, 2024 02:37
@petrochuk petrochuk changed the title Removed "Pa" prefix where is not necessary Removed "Pa" prefix where it is not necessary May 16, 2024
Copy link
Contributor

@joem-msft joem-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the issue you're trying to solve here? Please do not change anything in the PaYaml folders unless there is an actual feature that needs to be changed.

The PaYaml prefix in type names are by design.

  • The need for a type prefix is to provide unambiguous type names in code when multiple namespaces are added via using statements. This is the same issue we had to address the other day.
    e.g. this assembly now has two YamlSerializer classes:
    Microsoft.PowerPlatform.PowerApps.Persistence.PaYaml.Serialization.YamlSerializer
    and
    Microsoft.PowerPlatform.PowerApps.Persistence.Yaml.YamlSerializer
  • The name PaYaml is designed to correlate with most of these files have the file extension .pa.yaml.
  • The PaYaml in the namespace was intended to allow for the current OM and the new OM to live in the same assembly. It is a pragmatic design decision that allows for both OMs to be side-by-side at this time of transition. Eventually, the PaYaml namespace will likely be removed, renamed, and likely moved to a different assembly. Yet, the class names will not need to change since their use of 'PaYaml' is providing a different purpose.

@petrochuk petrochuk requested a review from joem-msft May 16, 2024 14:55
@petrochuk petrochuk dismissed joem-msft’s stale review May 16, 2024 23:28

Responded to comment

@petrochuk petrochuk merged commit 867f193 into master May 16, 2024
4 checks passed
@petrochuk petrochuk deleted the users/anpetroc/removed_pa branch May 16, 2024 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants