-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating navigation tree for settings with groupings #35559
Merged
Merged
Changes from 8 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
017f0ee
adjusting stuff from here to there
crutkas 576ba90
No longer crashing! a win!
crutkas bba687a
Resources now
crutkas 1a9a6e1
spelling
crutkas 8985ea0
Merge branch 'main' into dev/crutkas/newNav
crutkas 2cfb022
adjusting comments for xaml formatting
crutkas 8211c3b
added in new top level icons
ethanfangg 424523e
Fixing
crutkas 2de6681
adjusting the core container logic based on feedback. this is actual…
crutkas 059cb54
getting frame_nav functional again, thanks @davidegiacometti
crutkas 431b2f1
making a one time hit for union
crutkas 269200e
Update src/settings-ui/Settings.UI/ViewModels/ShellViewModel.cs
crutkas a6cdc17
expanding code that @davidegiacometti suggestedion. 🔥
crutkas 137d9a2
ensure parent is always expanded when page is changed
davidegiacometti e96fe83
don't use static
davidegiacometti 6b4585c
Merge branch 'main' into pr35559
jaimecbernardo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+1.46 KB
src/settings-ui/Settings.UI/Assets/Settings/Icons/WindowingAndLayouts.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
264 changes: 144 additions & 120 deletions
264
src/settings-ui/Settings.UI/SettingsXAML/Views/ShellPage.xaml
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -111,7 +111,11 @@ private void OnItemInvoked(NavigationViewItemInvokedEventArgs args) | |
.OfType<NavigationViewItem>() | ||
.First(menuItem => (string)menuItem.Content == (string)args.InvokedItem); | ||
var pageType = item.GetValue(NavHelper.NavigateToProperty) as Type; | ||
NavigationService.Navigate(pageType); | ||
|
||
if (pageType != null) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. without the L1 having a nav target, it would crash |
||
{ | ||
NavigationService.Navigate(pageType); | ||
} | ||
} | ||
|
||
private void OnBackRequested(NavigationView sender, NavigationViewBackRequestedEventArgs args) | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this was VS automatically adjusting this, fyi