-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[KeyboardManager] Fix shift on numpad #35890
base: main
Are you sure you want to change the base?
Conversation
Fixed shift not being released if a numpad key as shift.
@mantaionut please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
@microsoft-github-policy-service agree company="Microsoft" |
Summary of the Pull Request
Fix using a numpad key as shift.
PR Checklist
Detailed Description of the Pull Request / Additional comments
When receiving a numpad specific key, check if there is the numpad lock key with the same scan code that is overwriting shift and if it does, we overwrite the original key with the numpad key. I do this because when using for example numpad1 as shift we get the following scenario:
numpad end button
instead ofnumpad1
release since shift was also pressed.Validation Steps Performed
Replace numpad 1 with shift. Check that when releasing numpad1 shift gets toggled off.