Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5036
🏁 Race against the runtime!
basic_string::find
is already vectorized for 8 and 16 bit characters via callingmemchr
andwmemchr
memchr
shows good results for smaller positions, but if the distance from the beginning to the result is long thememchr
results are noticeably worse. There's strong indication that such a results are due to not using AVX inmemchr
.wmemchr
is not fast at all. It was promised to be fast in a new CRT in #4873 though.For larger characters the vectorization is novel, there's no CRT implementation, but these characters are rare anyway.
⏱️ Benchmark results