Skip to content

Commit

Permalink
Disable Correlation for Netsh traces (#233)
Browse files Browse the repository at this point in the history
# Description
Summary of changes:
- Configure `correlation=disabled` for netsh trace to prevent issue
where vm workload traffic disconnects when enabling tracing on vSwitch

# Change type
- [x] Bug fix (non-breaking change)
- [ ] Code style update (formatting, local variables)
- [ ] New Feature (non-breaking change that adds new functionality
without impacting existing)
- [ ] Breaking change (fix or feature that may cause functionality
impact)
- [ ] Other

# Checklist:
- [x] My code follows the style and contribution guidelines of this
project.
- [x] I have tested and validated my code changes.
  • Loading branch information
arudell authored Feb 13, 2024
1 parent c24368e commit 3e83d89
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 8 deletions.
8 changes: 4 additions & 4 deletions src/modules/SdnDiag.Common/private/Start-NetshTrace.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ function Start-NetshTrace {
.PARAMETER Overwrite
Optional. Specifies whether this instance of the trace conversion command overwrites files that were rendered from previous trace conversions. If unspecified, the default is Yes.
.PARAMETER Correlation
Optional. Specifies whether related events will be correlated and grouped together. If unspecified, the default is No.
Optional. Specifies whether related events will be correlated and grouped together. If unspecified, the default is disabled.
.PARAMETER Report
Optional. Specifies whether a complementing report will be generated in addition to the trace file report. If unspecified, the default is disabled.
.EXAMPLE
Expand Down Expand Up @@ -47,12 +47,12 @@ function Start-NetshTrace {
[System.String]$Overwrite = 'Yes',

[Parameter(Mandatory = $false)]
[ValidateSet('Enabled', 'Disabled')]
[ValidateSet('Yes', 'No', 'Disabled')]
[System.String]$Report = 'Disabled',

[Parameter(Mandatory = $false)]
[ValidateSet('Yes', 'No')]
[System.String]$Correlation = 'No'
[ValidateSet('Yes', 'No', 'Disabled')]
[System.String]$Correlation = 'Disabled'
)

try {
Expand Down
8 changes: 4 additions & 4 deletions src/modules/SdnDiag.Common/public/Start-SdnNetshTrace.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ function Start-SdnNetshTrace {
.PARAMETER Overwrite
Optional. Specifies whether this instance of the trace conversion command overwrites files that were rendered from previous trace conversions. If unspecified, the default is Yes.
.PARAMETER Correlation
Optional. Specifies whether related events will be correlated and grouped together. If unspecified, the default is No.
Optional. Specifies whether related events will be correlated and grouped together. If unspecified, the default is Disabled.
.PARAMETER Report
Optional. Specifies whether a complementing report will be generated in addition to the trace file report. If unspecified, the default is disabled.
.EXAMPLE
Expand Down Expand Up @@ -54,12 +54,12 @@ function Start-SdnNetshTrace {

[Parameter(Mandatory = $false, ParameterSetName = 'Local')]
[Parameter(Mandatory = $false, ParameterSetName = 'Remote')]
[ValidateSet('Yes', 'No')]
[System.String]$Correlation = 'No',
[ValidateSet('Yes', 'No', 'Disabled')]
[System.String]$Correlation = 'Disabled',

[Parameter(Mandatory = $false, ParameterSetName = 'Local')]
[Parameter(Mandatory = $false, ParameterSetName = 'Remote')]
[ValidateSet('Enabled', 'Disabled')]
[ValidateSet('Yes', 'No', 'Disabled')]
[System.String]$Report = 'Disabled',

[Parameter(Mandatory = $false, ParameterSetName = 'Local')]
Expand Down

0 comments on commit 3e83d89

Please sign in to comment.