Improve exception handling and logging (#248)

# Description
Summary of changes:
- Improvements to exception handling and logging

# Change type
- [ ] Bug fix (non-breaking change)
- [ ] Code style update (formatting, local variables)
- [x] New Feature (non-breaking change that adds new functionality
without impacting existing)
- [ ] Breaking change (fix or feature that may cause functionality
impact)
- [ ] Other

# Checklist:
- [x] My code follows the style and contribution guidelines of this
project.
- [x] I have tested and validated my code changes.

src/modules/SdnDiag.Common/private/Export-RegistryKeyConfigDetails.ps1

@@ -46,5 +46,6 @@ function Export-RegistryKeyConfigDetails {
     }
     catch {
         $_ | Trace-Exception
+        $_ | Write-Error
     }
 }

src/modules/SdnDiag.Common/private/Get-CommonConfigState.ps1

@@ -76,6 +76,7 @@ function Get-CommonConfigState {
     }
     catch {
         $_ | Trace-Exception
+        $_ | Write-Error
     }
 
     $ProgressPreference = 'Continue'

src/modules/SdnDiag.Common/private/Get-TraceProviders.ps1

@@ -75,5 +75,6 @@ function Get-TraceProviders {
     }
     catch {
         $_ | Trace-Exception
+        $_ | Write-Error
     }
 }

src/modules/SdnDiag.Common/private/Start-EtwTraceSession.ps1

@@ -54,5 +54,6 @@ function Start-EtwTraceSession {
     }
     catch {
         $_ | Trace-Exception
+        $_ | Write-Error
     }
 }

src/modules/SdnDiag.Common/private/Start-NetshTrace.ps1

@@ -109,5 +109,6 @@ function Start-NetshTrace {
     }
     catch {
         $_ | Trace-Exception
+        $_ | Write-Error
     }
 }

src/modules/SdnDiag.Common/private/Stop-EtwTraceSession.ps1

@@ -27,5 +27,6 @@ function Stop-EtwTraceSession {
     }
     catch {
         $_ | Trace-Exception
+        $_ | Write-Error
     }
 }

src/modules/SdnDiag.Common/private/Stop-NetshTrace.ps1

@@ -36,5 +36,6 @@ function Stop-NetshTrace {
     }
     catch {
         $_ | Trace-Exception
+        $_ | Write-Error
     }
 }

src/modules/SdnDiag.Common/public/Convert-SdnEtwTraceToTxt.ps1

@@ -81,5 +81,6 @@ function Convert-SdnEtwTraceToTxt {
     }
     catch {
         $_ | Trace-Exception
+        $_ | Write-Error
     }
 }

src/modules/SdnDiag.Common/public/Enable-SdnVipTrace.ps1

@@ -165,5 +165,6 @@ function Enable-SdnVipTrace {
     }
     catch {
         $_ | Trace-Exception
+        $_ | Write-Error
     }
 }

src/modules/SdnDiag.Common/public/Get-SdnCertificate.ps1

@@ -62,5 +62,6 @@ function Get-SdnCertificate {
     }
     catch {
         $_ | Trace-Exception
+        $_ | Write-Error
     }
 }

src/modules/SdnDiag.Common/public/Get-SdnEventLog.ps1

@@ -83,5 +83,6 @@ function Get-SdnEventLog {
     }
     catch {
         $_ | Trace-Exception
+        $_ | Write-Error
     }
 }

src/modules/SdnDiag.Common/public/Invoke-SdnGetNetView.ps1

@@ -74,5 +74,6 @@ function Invoke-SdnGetNetView {
     }
     catch {
         $_ | Trace-Exception
+        $_ | Write-Error
     }
 }

src/modules/SdnDiag.Common/public/New-SdnCertificate.ps1

@@ -50,5 +50,6 @@ function New-SdnCertificate {
     }
     catch {
         $_ | Trace-Exception
+        $_ | Write-Error
     }
 }

src/modules/SdnDiag.Common/public/Repair-SdnDiagnosticsScheduledTask.ps1

@@ -37,5 +37,6 @@ function Repair-SdnDiagnosticsScheduledTask {
     }
     catch {
         $_ | Trace-Exception
+        $_ | Write-Error
     }
 }

src/modules/SdnDiag.Common/public/Set-SdnCertificateAcl.ps1

@@ -71,5 +71,6 @@ function Set-SdnCertificateAcl {
     }
     catch {
         $_ | Trace-Exception
+        $_ | Write-Error
     }
 }

src/modules/SdnDiag.Common/public/Start-SdnEtwTraceCapture.ps1

@@ -42,5 +42,6 @@ function Start-SdnEtwTraceCapture {
     }
     catch {
         $_ | Trace-Exception
+        $_ | Write-Error
     }
 }

src/modules/SdnDiag.Common/public/Start-SdnNetshTrace.ps1

@@ -130,5 +130,6 @@ function Start-SdnNetshTrace {
     }
     catch {
         $_ | Trace-Exception
+        $_ | Write-Error
     }
 }

src/modules/SdnDiag.Common/public/Stop-SdnEtwTraceCapture.ps1

@@ -29,5 +29,6 @@ function Stop-SdnEtwTraceCapture {
     }
     catch {
         $_ | Trace-Exception
+        $_ | Write-Error
     }
 }

src/modules/SdnDiag.Common/public/Stop-SdnNetshTrace.ps1

@@ -31,5 +31,6 @@ function Stop-SdnNetshTrace {
     }
     catch {
         $_ | Trace-Exception
+        $_ | Write-Error
     }
 }

src/modules/SdnDiag.Gateway/private/Get-GatewayConfigState.ps1

@@ -74,6 +74,7 @@ function Get-GatewayConfigState {
     }
     catch {
         $_ | Trace-Exception
+        $_ | Write-Error
     }
 
     $ProgressPreference = 'Continue'

src/modules/SdnDiag.Gateway/public/Disable-SdnRasGatewayTracing.ps1

@@ -22,5 +22,6 @@ function Disable-SdnRasGatewayTracing {
     }
     catch {
         $_ | Trace-Exception
+        $_ | Write-Error
     }
 }

src/modules/SdnDiag.Gateway/public/Enable-SdnRasGatewayTracing.ps1

@@ -37,5 +37,6 @@ function Enable-SdnRasGatewayTracing {
     }
     catch {
         $_ | Trace-Exception
+        $_ | Write-Error
     }
 }

src/modules/SdnDiag.Health/private/Test-EncapOverhead.ps1

@@ -63,5 +63,6 @@ function Test-EncapOverhead {
     }
     catch {
         $_ | Trace-Exception
+        $_ | Write-Error
     }
 }

src/modules/SdnDiag.Health/private/Test-HostRootStoreNonRootCert.ps1

@@ -62,5 +62,6 @@ function Test-HostRootStoreNonRootCert {
     }
     catch {
         $_ | Trace-Exception
+        $_ | Write-Error
     }
 }

src/modules/SdnDiag.Health/private/Test-MuxBgpConnectionState.ps1

@@ -71,5 +71,6 @@ function Test-MuxBgpConnectionState {
     }
     catch {
         $_ | Trace-Exception
+        $_ | Write-Error
     }
 }

src/modules/SdnDiag.Health/private/Test-NcHostAgentConnectionToApiService.ps1

@@ -78,5 +78,6 @@ function Test-NcHostAgentConnectionToApiService {
     }
     catch {
         $_ | Trace-Exception
+        $_ | Write-Error
     }
 }

src/modules/SdnDiag.Health/private/Test-NcUrlNameResolution.ps1

@@ -78,5 +78,6 @@ function Test-NcUrlNameResolution {
     }
     catch {
         $_ | Trace-Exception
+        $_ | Write-Error
     }
 }

src/modules/SdnDiag.Health/private/Test-NetworkControllerCertCredential.ps1

@@ -88,5 +88,6 @@ function Test-NetworkControllerCertCredential {
     }
     catch {
         $_ | Trace-Exception
+        $_ | Write-Error
     }
 }

src/modules/SdnDiag.Health/private/Test-NetworkInterfaceAPIDuplicateMacAddress.ps1

@@ -53,5 +53,6 @@ function Test-NetworkInterfaceAPIDuplicateMacAddress {
     }
     catch {
         $_ | Trace-Exception
+        $_ | Write-Error
     }
 }

src/modules/SdnDiag.Health/private/Test-ProviderNetwork.ps1

@@ -74,5 +74,6 @@ function Test-ProviderNetwork {
     }
     catch {
         $_ | Trace-Exception
+        $_ | Write-Error
     }
 }

src/modules/SdnDiag.Health/private/Test-ResourceConfigurationState.ps1

@@ -117,5 +117,6 @@ function Test-ResourceConfigurationState {
     }
     catch {
         $_ | Trace-Exception
+        $_ | Write-Error
     }
 }

src/modules/SdnDiag.Health/private/Test-ResourceProvisioningState.ps1

@@ -65,5 +65,6 @@ function Test-ResourceProvisioningState {
     }
     catch {
         $_ | Trace-Exception
+        $_ | Write-Error
     }
 }

src/modules/SdnDiag.Health/private/Test-ScheduledTaskEnabled.ps1

@@ -79,5 +79,6 @@ function Test-ScheduledTaskEnabled {
     }
     catch {
         $_ | Trace-Exception
+        $_ | Write-Error
     }
 }

src/modules/SdnDiag.Health/private/Test-ServerHostId.ps1

@@ -56,5 +56,6 @@ function Test-ServerHostId {
     }
     catch {
         $_ | Trace-Exception
+        $_ | Write-Error
     }
 }

src/modules/SdnDiag.Health/private/Test-ServiceFabricApplicationHealth.ps1

@@ -35,5 +35,6 @@ function Test-ServiceFabricApplicationHealth {
     }
     catch {
         $_ | Trace-Exception
+        $_ | Write-Error
     }
 }

src/modules/SdnDiag.Health/private/Test-ServiceFabricClusterHealth.ps1

@@ -35,5 +35,6 @@ function Test-ServiceFabricClusterHealth {
     }
     catch {
         $_ | Trace-Exception
+        $_ | Write-Error
     }
 }

src/modules/SdnDiag.Health/private/Test-ServiceFabricNodeStatus.ps1

@@ -36,5 +36,6 @@ function Test-ServiceFabricNodeStatus {
     }
     catch {
         $_ | Trace-Exception
+        $_ | Write-Error
     }
 }

src/modules/SdnDiag.Health/private/Test-ServiceFabricPartitionDatabaseSize.ps1

@@ -87,5 +87,6 @@ function Test-ServiceFabricPartitionDatabaseSize {
     }
     catch {
         $_ | Trace-Exception
+        $_ | Write-Error
     }
 }

src/modules/SdnDiag.Health/private/Test-ServiceState.ps1

@@ -53,5 +53,6 @@ function Test-ServiceState {
     }
     catch {
         $_ | Trace-Exception
+        $_ | Write-Error
     }
 }

src/modules/SdnDiag.Health/private/Test-SlbManagerConnectionToMux.ps1

@@ -78,5 +78,6 @@ function Test-SlbManagerConnectionToMux {
     }
     catch {
         $_ | Trace-Exception
+        $_ | Write-Error
     }
 }

src/modules/SdnDiag.Health/private/Test-VMNetAdapterDuplicateMacAddress.ps1

@@ -44,5 +44,6 @@ function Test-VMNetAdapterDuplicateMacAddress {
     }
     catch {
         $_ | Trace-Exception
+        $_ | Write-Error
     }
 }

src/modules/SdnDiag.Health/private/Test-VfpDuplicatePort.ps1

@@ -45,5 +45,6 @@ function Test-VfpDuplicatePort {
     }
     catch {
         $_ | Trace-Exception
+        $_ | Write-Error
     }
 }

src/modules/SdnDiag.Health/public/Debug-SdnFabricInfrastructure.ps1

@@ -226,5 +226,6 @@ function Debug-SdnFabricInfrastructure {
     }
     catch {
         $_ | Trace-Exception
+        $_ | Write-Error
     }
 }

src/modules/SdnDiag.LoadBalancerMux/private/Get-SlbMuxConfigState.ps1

@@ -45,6 +45,7 @@ function Get-SlbMuxConfigState {
     }
     catch {
         $_ | Trace-Exception
+        $_ | Write-Error
     }
 
     $ProgressPreference = 'Continue'

src/modules/SdnDiag.LoadBalancerMux/public/Get-SdnMuxCertificate.ps1

@@ -15,5 +15,6 @@ function Get-SdnMuxCertificate {
     }
     catch {
         $_ | Trace-Exception
+        $_ | Write-Error
     }
 }

src/modules/SdnDiag.LoadBalancerMux/public/Get-SdnMuxDistributedRouterIP.ps1

@@ -32,5 +32,6 @@ function Get-SdnMuxDistributedRouterIP {
     }
     catch {
         $_ | Trace-Exception
+        $_ | Write-Error
     }
 }

src/modules/SdnDiag.LoadBalancerMux/public/Get-SdnMuxState.ps1

@@ -10,5 +10,6 @@ function Get-SdnMuxState {
     }
     catch {
         $_ | Trace-Exception
+        $_ | Write-Error
     }
 }

src/modules/SdnDiag.LoadBalancerMux/public/Get-SdnMuxStatefulVip.ps1

@@ -32,5 +32,6 @@ function Get-SdnMuxStatefulVip {
     }
     catch {
         $_ | Trace-Exception
+        $_ | Write-Error
     }
 }

src/modules/SdnDiag.LoadBalancerMux/public/Get-SdnMuxStatelessVip.ps1

@@ -32,5 +32,6 @@ function Get-SdnMuxStatelessVip {
     }
     catch {
         $_ | Trace-Exception
+        $_ | Write-Error
     }
 }

src/modules/SdnDiag.LoadBalancerMux/public/Get-SdnMuxStats.ps1

@@ -27,5 +27,6 @@ function Get-SdnMuxStats {
     }
     catch {
         $_ | Trace-Exception
+        $_ | Write-Error
     }
 }

src/modules/SdnDiag.LoadBalancerMux/public/Get-SdnMuxVip.ps1

@@ -32,5 +32,6 @@ function Get-SdnMuxVip {
     }
     catch {
         $_ | Trace-Exception
+        $_ | Write-Error
     }
 }

src/modules/SdnDiag.LoadBalancerMux/public/Get-SdnMuxVipConfig.ps1

@@ -38,5 +38,6 @@ function Get-SdnMuxVipConfig {
     }
     catch {
         $_ | Trace-Exception
+        $_ | Write-Error
     }
 }

src/modules/SdnDiag.LoadBalancerMux/public/New-SdnMuxCertificate.ps1

@@ -71,5 +71,6 @@ function New-SdnMuxCertificate {
     }
     catch {
         $_ | Trace-Exception
+        $_ | Write-Error
     }
 }

src/modules/SdnDiag.LoadBalancerMux/public/Start-SdnMuxCertificateRotation.ps1

@@ -201,5 +201,6 @@ function Start-SdnMuxCertificateRotation {
     }
     catch {
         $_ | Trace-Exception
+        $_ | Write-Error
     }
 }