Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude testing ILB PA IPs from Logical Network testing #386

Merged
merged 4 commits into from
Feb 10, 2025
Merged

Exclude testing ILB PA IPs from Logical Network testing #386

merged 4 commits into from
Feb 10, 2025

Conversation

arudell
Copy link
Member

@arudell arudell commented Feb 10, 2025 •
edited
Loading

Description

Summary of changes:

  • Added filtering to ensure that ILB PA IPs are excluded from tests regarding PA IPs, as commonly will be on different VLANs.

Change type

  • Bug fix (non-breaking change)
  • Code style update (formatting, local variables)
  • New Feature (non-breaking change that adds new functionality without impacting existing)
  • Breaking change (fix or feature that may cause functionality impact)
  • Other

Checklist:

  • My code follows the style and contribution guidelines of this project.
  • I have tested and validated my code changes.

@arudell arudell marked this pull request as ready for review February 10, 2025 17:49
@arudell arudell requested a review from a team as a code owner February 10, 2025 17:49
@arudell arudell added this pull request to the merge queue Feb 10, 2025
Merged via the queue into main with commit 9581d44 Feb 10, 2025
4 of 5 checks passed
@arudell arudell deleted the improve-logging-for-health-tests branch February 10, 2025 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbgms sbgms sbgms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arudell @sbgms