[WIP] Phi3poc #2301

JessicaXYWang · 2024-10-15T06:12:05Z

Related Issues/PRs

#xxx

What changes are proposed in this pull request?

Briefly describe the changes included in this Pull Request.

How is this patch tested?

I have written tests (not required for typo or doc fix) and confirmed the proposed feature/bug-fix/change works.

Does this PR change any dependencies?

No. You can skip this section.
Yes. Make sure the dependencies are resolved correctly, and list changes here.

Does this PR add a new feature? If so, have you added samples on website?

No. You can skip this section.
Yes. Make sure you have added samples following below steps.

Find the corresponding markdown file for your new feature in website/docs/documentation folder.
Make sure you choose the correct class estimators/transformers and namespace.
Follow the pattern in markdown file and add another section for your new API, including pyspark, scala (and .NET potentially) samples.
Make sure the DocTable points to correct API link.
Navigate to website folder, and run yarn run start to make sure the website renders correctly.
Don't forget to add  before each python code blocks to enable auto-tests for python samples.
Make sure the WebsiteSamplesTests job pass in the pipeline.

JessicaXYWang · 2024-10-15T06:12:29Z

/azp run

azure-pipelines · 2024-10-15T06:12:39Z

Azure Pipelines successfully started running 1 pipeline(s).

codecov-commenter · 2024-10-15T06:24:19Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.41%. Comparing base (b2f4080) to head (0d7aafd).

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2301      +/-   ##
==========================================
- Coverage   83.67%   83.41%   -0.27%     
==========================================
  Files         331      331              
  Lines       17177    17177              
  Branches     1526     1526              
==========================================
- Hits        14373    14328      -45     
- Misses       2804     2849      +45

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…into phi3poc

JessicaXYWang · 2024-10-15T15:03:21Z

/azp run

azure-pipelines · 2024-10-15T15:03:34Z

Azure Pipelines successfully started running 1 pipeline(s).

JessicaXYWang · 2024-10-17T22:04:34Z

/azp run

azure-pipelines · 2024-10-17T22:04:45Z

Azure Pipelines successfully started running 1 pipeline(s).

JessicaXYWang · 2024-10-24T17:32:10Z

/azp run

azure-pipelines · 2024-10-24T17:32:23Z

Azure Pipelines successfully started running 1 pipeline(s).

JessicaXYWang · 2025-01-02T16:13:34Z

/azp run

azure-pipelines · 2025-01-02T16:13:47Z

Azure Pipelines successfully started running 1 pipeline(s).

core/src/main/python/synapse/ml/llm/HuggingFaceCausallmTransform.py

mhamilton723 · 2025-01-02T17:38:36Z

core/src/main/python/synapse/ml/llm/HuggingFaceCausallmTransform.py

+        self.config.update(kwargs)
+
+
+def camel_to_snake(text):


there might already be one in library to use

mhamilton723 · 2025-01-02T17:39:06Z

core/src/main/python/synapse/ml/llm/HuggingFaceCausallmTransform.py

+        "output column",
+        typeConverter=TypeConverters.toString,
+    )
+    modelParam = Param(Params._dummy(), "modelParam", "Model Parameters")


Maybe explain difference between model params and other params (you can just link to other docs if easier)

mhamilton723 · 2025-01-02T17:39:22Z

core/src/main/python/synapse/ml/llm/HuggingFaceCausallmTransform.py

+        typeConverter=TypeConverters.toString,
+    )
+    modelParam = Param(Params._dummy(), "modelParam", "Model Parameters")
+    modelConfig = Param(Params._dummy(), "modelConfig", "Model configuration")


Maybe explain difference between model config and other params (you can just link to other docs if easier)

mhamilton723 · 2025-01-02T17:39:39Z

core/src/main/python/synapse/ml/llm/HuggingFaceCausallmTransform.py

+    useFabricLakehouse = Param(
+        Params._dummy(),
+        "useFabricLakehouse",
+        "Use FabricLakehouse",


If this is for a local cache then you might be able to make the verbage generic like useLocalCache

…into phi3poc

JessicaXYWang · 2025-03-04T05:36:08Z

/azp run

azure-pipelines · 2025-03-04T05:36:19Z

Azure Pipelines successfully started running 1 pipeline(s).

JessicaXYWang · 2025-03-04T18:07:19Z

/azp run

azure-pipelines · 2025-03-04T18:07:31Z

Azure Pipelines successfully started running 1 pipeline(s).

JessicaXYWang · 2025-03-04T23:40:10Z

/azp run

azure-pipelines · 2025-03-04T23:40:21Z

Azure Pipelines successfully started running 1 pipeline(s).

JessicaXYWang · 2025-03-05T19:39:08Z

/azp run

azure-pipelines · 2025-03-05T19:39:20Z

Azure Pipelines successfully started running 1 pipeline(s).

JessicaXYWang · 2025-03-05T21:28:23Z

/azp run

azure-pipelines · 2025-03-05T21:28:35Z

Azure Pipelines successfully started running 1 pipeline(s).

JessicaXYWang · 2025-03-06T03:58:11Z

/azp run

azure-pipelines · 2025-03-06T03:58:22Z

Azure Pipelines successfully started running 1 pipeline(s).

JessicaXYWang · 2025-03-06T04:48:11Z

/azp run

azure-pipelines · 2025-03-06T04:48:22Z

Azure Pipelines successfully started running 1 pipeline(s).

JessicaXYWang · 2025-03-06T07:39:52Z

/azp run

azure-pipelines · 2025-03-06T07:40:05Z

Azure Pipelines successfully started running 1 pipeline(s).

mhamilton723 · 2025-03-06T17:41:33Z

core/src/main/python/synapse/ml/llm/HuggingFaceCausallmTransform.py

+    return re.sub(r"(?<!^)(?=[A-Z])", "_", text).lower()
+
+
+class ComputableObject:


nit: rename to _BroadcastableModel

mhamilton723 · 2025-03-06T17:43:56Z

core/src/main/python/synapse/ml/llm/HuggingFaceCausallmTransform.py

+        if value is not None:
+            bc_computable = ComputableObject(value, self.getModelConfig())
+            sc = SparkSession.builder.getOrCreate().sparkContext
+            self.bcObject = sc.broadcast(bc_computable)
+        else:
+            self.bcObject = None


dont do this here

mhamilton723 · 2025-03-06T17:44:16Z

core/src/main/python/synapse/ml/llm/HuggingFaceCausallmTransform.py

+        if self.getCachePath():
+            bc_computable = ComputableObject(self.getCachePath(), self.getModelConfig())
+            sc = SparkSession.builder.getOrCreate().sparkContext
+            self.bcObject = sc.broadcast(bc_computable)
+        else:
+            self.bcObject = None


do this in transform

mhamilton723 · 2025-03-06T17:46:56Z

core/src/main/python/synapse/ml/llm/HuggingFaceCausallmTransform.py

+    modelName = Param(
+        Params._dummy(),
+        "modelName",
+        "model name",


might want to link to the list of models on huggingface

mhamilton723 · 2025-03-06T17:47:24Z

core/src/main/python/synapse/ml/llm/HuggingFaceCausallmTransform.py

+    cachePath = Param(
+        Params._dummy(),
+        "cachePath",
+        "cache path for the model. could be a lakehouse path",


we should mention that this should be a shared location between the workers

mhamilton723 · 2025-03-06T17:47:43Z

core/src/main/python/synapse/ml/llm/HuggingFaceCausallmTransform.py

+    deviceMap = Param(
+        Params._dummy(),
+        "deviceMap",
+        "Specifies a model parameter for the device Map. For GPU usage with models such as Phi 3, set it to 'cuda'.",


no need to mention phi3 specifically here

JessicaXYWang added 2 commits September 12, 2024 09:28

poc

f0c2b00

poc

603777a

JessicaXYWang requested a review from mhamilton723 as a code owner October 15, 2024 06:12

Merge branch 'master' into phi3poc

47ae241

JessicaXYWang added 2 commits October 15, 2024 08:02

rename module

23f8ca0

Merge branch 'phi3poc' of https://github.com/JessicaXYWang/SynapseML …

bb5b2b6

…into phi3poc

JessicaXYWang added 2 commits October 17, 2024 15:03

update dependency

f235535

Merge branch 'master' into phi3poc

f2ab308

add set device type

3ee9168

JessicaXYWang added 3 commits January 2, 2025 08:11

add Downloader

b30f168

remove import

d760733

Merge branch 'master' into phi3poc

6efa59c

mhamilton723 reviewed Jan 2, 2025

View reviewed changes

core/src/main/python/synapse/ml/llm/HuggingFaceCausallmTransform.py Outdated Show resolved Hide resolved

mhamilton723 reviewed Jan 2, 2025

View reviewed changes

core/src/main/python/synapse/ml/llm/HuggingFaceCausallmTransform.py Outdated Show resolved Hide resolved

mhamilton723 reviewed Jan 2, 2025

View reviewed changes

core/src/main/python/synapse/ml/llm/HuggingFaceCausallmTransform.py Outdated Show resolved Hide resolved

mhamilton723 reviewed Jan 2, 2025

View reviewed changes

Merge branch 'phi3poc' of https://github.com/JessicaXYWang/SynapseML …

caf6de7

…into phi3poc

test with previous transformers version

346615f

test

72aa18e

test env

87edc13

test

5fcb372

test

068bd99

test

8282df4

test

0d7aafd

mhamilton723 reviewed Mar 6, 2025

View reviewed changes

		return re.sub(r"(?<!^)(?=[A-Z])", "_", text).lower()


		class ComputableObject:

[WIP] Phi3poc #2301

Are you sure you want to change the base?

[WIP] Phi3poc #2301

Conversation

JessicaXYWang commented Oct 15, 2024

Related Issues/PRs

What changes are proposed in this pull request?

How is this patch tested?

Does this PR change any dependencies?

Does this PR add a new feature? If so, have you added samples on website?

JessicaXYWang commented Oct 15, 2024

azure-pipelines bot commented Oct 15, 2024

codecov-commenter commented Oct 15, 2024 • edited Loading

Codecov Report

JessicaXYWang commented Oct 15, 2024

azure-pipelines bot commented Oct 15, 2024

JessicaXYWang commented Oct 17, 2024

azure-pipelines bot commented Oct 17, 2024

JessicaXYWang commented Oct 24, 2024

azure-pipelines bot commented Oct 24, 2024

JessicaXYWang commented Jan 2, 2025

azure-pipelines bot commented Jan 2, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mhamilton723 Jan 2, 2025 • edited Loading

Choose a reason for hiding this comment

JessicaXYWang commented Mar 4, 2025

azure-pipelines bot commented Mar 4, 2025

JessicaXYWang commented Mar 4, 2025

azure-pipelines bot commented Mar 4, 2025

JessicaXYWang commented Mar 4, 2025

azure-pipelines bot commented Mar 4, 2025

JessicaXYWang commented Mar 5, 2025

azure-pipelines bot commented Mar 5, 2025

JessicaXYWang commented Mar 5, 2025

azure-pipelines bot commented Mar 5, 2025

JessicaXYWang commented Mar 6, 2025

azure-pipelines bot commented Mar 6, 2025

JessicaXYWang commented Mar 6, 2025

azure-pipelines bot commented Mar 6, 2025

JessicaXYWang commented Mar 6, 2025

azure-pipelines bot commented Mar 6, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov-commenter commented Oct 15, 2024 •

edited

Loading

mhamilton723 Jan 2, 2025 •

edited

Loading