Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Phi3poc #2301

Open
wants to merge 37 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
f0c2b00
poc
JessicaXYWang Sep 12, 2024
603777a
poc
JessicaXYWang Oct 15, 2024
47ae241
Merge branch 'master' into phi3poc
JessicaXYWang Oct 15, 2024
23f8ca0
rename module
JessicaXYWang Oct 15, 2024
bb5b2b6
Merge branch 'phi3poc' of https://github.com/JessicaXYWang/SynapseML …
JessicaXYWang Oct 15, 2024
f235535
update dependency
JessicaXYWang Oct 17, 2024
f2ab308
Merge branch 'master' into phi3poc
JessicaXYWang Oct 17, 2024
3ee9168
add set device type
JessicaXYWang Oct 21, 2024
b30f168
add Downloader
JessicaXYWang Jan 2, 2025
d760733
remove import
JessicaXYWang Jan 2, 2025
6efa59c
Merge branch 'master' into phi3poc
JessicaXYWang Jan 2, 2025
c7397f3
update lm
JessicaXYWang Jan 10, 2025
e1105fd
Merge branch 'phi3poc' of https://github.com/JessicaXYWang/SynapseML …
JessicaXYWang Jan 10, 2025
e59a981
Merge branch 'master' into phi3poc
JessicaXYWang Jan 10, 2025
ff8ad7f
pyarrow version conflict
JessicaXYWang Jan 13, 2025
56e623d
Merge branch 'phi3poc' of https://github.com/JessicaXYWang/SynapseML …
JessicaXYWang Jan 13, 2025
efa6aa0
update transformers version
JessicaXYWang Jan 14, 2025
2f5338c
add dependency
JessicaXYWang Jan 14, 2025
ff89511
update transformers version
JessicaXYWang Jan 14, 2025
b3dc5da
add phi3 test
JessicaXYWang Jan 16, 2025
c0cd463
test missing transformers library
JessicaXYWang Jan 16, 2025
e3e331c
update databricks test
JessicaXYWang Jan 16, 2025
382a20e
update databricks test
JessicaXYWang Jan 16, 2025
0a0f80c
update db library
JessicaXYWang Jan 17, 2025
eac0293
update doc
JessicaXYWang Jan 23, 2025
7a3e315
format
JessicaXYWang Jan 23, 2025
465161a
add broadcast model
JessicaXYWang Mar 3, 2025
4c059dc
Merge branch 'master' into phi3poc
JessicaXYWang Mar 3, 2025
4b91579
temporarily remove horovod for testing
JessicaXYWang Mar 4, 2025
caf6de7
Merge branch 'phi3poc' of https://github.com/JessicaXYWang/SynapseML …
JessicaXYWang Mar 4, 2025
346615f
test with previous transformers version
JessicaXYWang Mar 4, 2025
72aa18e
test
JessicaXYWang Mar 4, 2025
87edc13
test env
JessicaXYWang Mar 5, 2025
5fcb372
test
JessicaXYWang Mar 5, 2025
068bd99
test
JessicaXYWang Mar 6, 2025
8282df4
test
JessicaXYWang Mar 6, 2025
0d7aafd
test
JessicaXYWang Mar 6, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions build.sbt
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ val extraDependencies = Seq(
"org.apache.httpcomponents.client5" % "httpclient5" % "5.1.3",
"org.apache.httpcomponents" % "httpmime" % "4.5.13",
"com.linkedin.isolation-forest" %% "isolation-forest_3.4.2" % "3.0.4"
//, "org.apache.hadoop" % "hadoop-client-api" % "3.3.4"
exclude("com.google.protobuf", "protobuf-java") exclude("org.apache.spark", "spark-mllib_2.12")
exclude("org.apache.spark", "spark-core_2.12") exclude("org.apache.spark", "spark-avro_2.12")
exclude("org.apache.spark", "spark-sql_2.12"),
Expand Down
325 changes: 325 additions & 0 deletions core/src/main/python/synapse/ml/llm/HuggingFaceCausallmTransform.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,325 @@
from pyspark.ml import Transformer
from pyspark.ml.param.shared import (
HasInputCol,
HasOutputCol,
Param,
Params,
TypeConverters,
)
from pyspark.sql import Row, SparkSession
from pyspark.sql.functions import udf
from pyspark.sql.types import StringType, StructType, StructField
from pyspark.ml.util import DefaultParamsReadable, DefaultParamsWritable
from transformers import AutoTokenizer, AutoModelForCausalLM
from pyspark import keyword_only
import re
import os


class _PeekableIterator:
def __init__(self, iterable):
self._iterator = iter(iterable)
self._cache = []

def __iter__(self):
return self

def __next__(self):
if self._cache:
return self._cache.pop(0)
else:
return next(self._iterator)

def peek(self, n=1):
"""Peek at the next n elements without consuming them."""
while len(self._cache) < n:
try:
self._cache.append(next(self._iterator))
except StopIteration:
break
if n == 1:
return self._cache[0] if self._cache else None
else:
return self._cache[:n]


class _ModelParam:
def __init__(self, **kwargs):
self.param = {}
self.param.update(kwargs)

def get_param(self):
return self.param


class _ModelConfig:
def __init__(self, **kwargs):
self.config = {}
self.config.update(kwargs)

def get_config(self):
return self.config

def set_config(self, **kwargs):
self.config.update(kwargs)


def camel_to_snake(text):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there might already be one in library to use

return re.sub(r"(?<!^)(?=[A-Z])", "_", text).lower()


class ComputableObject:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: rename to _BroadcastableModel


def __init__(self, model_path=None, model_config=None):
self.model_path = model_path
self.model = None
self.tokenizer = None
self.model_config = model_config


def load_model(self):
if self.model_path and os.path.exists(self.model_path):
model_config = self.model_config.get_config()
self.model = AutoModelForCausalLM.from_pretrained(self.model_path, local_files_only=True, **model_config)
self.tokenizer = AutoTokenizer.from_pretrained(self.model_path, local_files_only=True)
else:
raise ValueError(f"Model path {self.model_path} does not exist.")

def __getstate__(self):
return {"model_path": self.model_path, "model_config": self.model_config}

def __setstate__(self, state):
self.model_path = state.get("model_path")
self.model_config = state.get("model_config")
self.model = None
self.tokenizer = None
if self.model_path:
self.load_model()

class HuggingFaceCausalLM(
Transformer, HasInputCol, HasOutputCol, DefaultParamsReadable, DefaultParamsWritable
):

modelName = Param(
Params._dummy(),
"modelName",
"model name",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might want to link to the list of models on huggingface

typeConverter=TypeConverters.toString,
)
inputCol = Param(
Params._dummy(),
"inputCol",
"input column",
typeConverter=TypeConverters.toString,
)
outputCol = Param(
Params._dummy(),
"outputCol",
"output column",
typeConverter=TypeConverters.toString,
)
modelParam = Param(
Params._dummy(),
"modelParam",
"Model Parameters, passed to .generate(). For more details, check https://huggingface.co/docs/transformers/en/main_classes/text_generation#transformers.GenerationConfig",
)
modelConfig = Param(
Params._dummy(),
"modelConfig",
"Model configuration, passed to AutoModelForCausalLM.from_pretrained(). For more details, check https://huggingface.co/docs/transformers/en/model_doc/auto#transformers.AutoModelForCausalLM",
)
cachePath = Param(
Params._dummy(),
"cachePath",
"cache path for the model. could be a lakehouse path",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should mention that this should be a shared location between the workers

typeConverter=TypeConverters.toString,
)
deviceMap = Param(
Params._dummy(),
"deviceMap",
"Specifies a model parameter for the device Map. For GPU usage with models such as Phi 3, set it to 'cuda'.",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need to mention phi3 specifically here

typeConverter=TypeConverters.toString,
)
torchDtype = Param(
Params._dummy(),
"torchDtype",
"Specifies a model parameter for the torch dtype. For GPU usage with models such as Phi 3, set it to 'auto'.",
typeConverter=TypeConverters.toString,
)

@keyword_only
def __init__(
self,
modelName=None,
inputCol=None,
outputCol=None,
cachePath=None,
deviceMap=None,
torchDtype=None,
):
super(HuggingFaceCausalLM, self).__init__()
self._setDefault(
modelName=modelName,
inputCol=inputCol,
outputCol=outputCol,
modelParam=_ModelParam(),
modelConfig=_ModelConfig(),
cachePath=None,
deviceMap=None,
torchDtype=None,
)
kwargs = self._input_kwargs
self.setParams(**kwargs)

if self.getCachePath():
bc_computable = ComputableObject(self.getCachePath(), self.getModelConfig())
sc = SparkSession.builder.getOrCreate().sparkContext
self.bcObject = sc.broadcast(bc_computable)
else:
self.bcObject = None
Comment on lines +174 to +179
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do this in transform


@keyword_only
def setParams(self):
kwargs = self._input_kwargs
return self._set(**kwargs)

def setModelName(self, value):
return self._set(modelName=value)

def getModelName(self):
return self.getOrDefault(self.modelName)

def setInputCol(self, value):
return self._set(inputCol=value)

def getInputCol(self):
return self.getOrDefault(self.inputCol)

def setOutputCol(self, value):
return self._set(outputCol=value)

def getOutputCol(self):
return self.getOrDefault(self.outputCol)

def setModelParam(self, **kwargs):
param = _ModelParam(**kwargs)
return self._set(modelParam=param)

def getModelParam(self):
return self.getOrDefault(self.modelParam)

def setModelConfig(self, **kwargs):
config = _ModelConfig(**kwargs)
return self._set(modelConfig=config)

def getModelConfig(self):
return self.getOrDefault(self.modelConfig)

def setCachePath(self, value):
ret = self._set(cachePath=value)
if value is not None:
bc_computable = ComputableObject(value, self.getModelConfig())
sc = SparkSession.builder.getOrCreate().sparkContext
self.bcObject = sc.broadcast(bc_computable)
else:
self.bcObject = None
Comment on lines +220 to +225
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dont do this here

return ret

def getCachePath(self):
return self.getOrDefault(self.cachePath)

def setDeviceMap(self, value):
return self._set(deviceMap=value)

def getDeviceMap(self):
return self.getOrDefault(self.deviceMap)

def setTorchDtype(self, value):
return self._set(torchDtype=value)

def getTorchDtype(self):
return self.getOrDefault(self.torchDtype)

def getBCObject(self):
return self.bcObject

def _predict_single_complete(self, prompt, model, tokenizer):
param = self.getModelParam().get_param()
inputs = tokenizer(prompt, return_tensors="pt").input_ids
outputs = model.generate(inputs, **param)
decoded_output = tokenizer.batch_decode(outputs, skip_special_tokens=True)[0]
return decoded_output

def _predict_single_chat(self, prompt, model, tokenizer):
param = self.getModelParam().get_param()
if isinstance(prompt, list):
chat = prompt
else:
chat = [{"role": "user", "content": prompt}]
formatted_chat = tokenizer.apply_chat_template(
chat, tokenize=False, add_generation_prompt=True
)
tokenized_chat = tokenizer(
formatted_chat, return_tensors="pt", add_special_tokens=False
)
inputs = {
key: tensor.to(model.device) for key, tensor in tokenized_chat.items()
}
merged_inputs = {**inputs, **param}
outputs = model.generate(**merged_inputs)
decoded_output = tokenizer.decode(
outputs[0][inputs["input_ids"].size(1) :], skip_special_tokens=True
)
return decoded_output

def _process_partition(self, iterator, task, bc_object):
"""Process each partition of the data."""
peekable_iterator = _PeekableIterator(iterator)
try:
first_row = peekable_iterator.peek()
except StopIteration:
return None

if bc_object:
lc_object = bc_object.value
model = lc_object.model
tokenizer = lc_object.tokenizer
else:
model_name = self.getModelName()
model_config = self.getModelConfig().get_config()
model = AutoModelForCausalLM.from_pretrained(model_name, **model_config)
tokenizer = AutoTokenizer.from_pretrained(model_name)

for row in peekable_iterator:
prompt = row[self.getInputCol()]
if task == "chat":
result = self._predict_single_chat(prompt, model, tokenizer)
elif task == "complete":
result = self._predict_single_complete(prompt, model, tokenizer)
row_dict = row.asDict()
row_dict[self.getOutputCol()] = result
yield Row(**row_dict)

def _transform(self, dataset):
bc_object = self.getBCObject()
input_schema = dataset.schema
output_schema = StructType(
input_schema.fields + [StructField(self.getOutputCol(), StringType(), True)]
)
result_rdd = dataset.rdd.mapPartitions(
lambda partition: self._process_partition(partition, "chat", bc_object)
)
result_df = result_rdd.toDF(output_schema)
return result_df

def complete(self, dataset):
bc_object = self.getBCObject()
input_schema = dataset.schema
output_schema = StructType(
input_schema.fields + [StructField(self.getOutputCol(), StringType(), True)]
)
result_rdd = dataset.rdd.mapPartitions(
lambda partition: self._process_partition(partition, "complete", bc_object)
)
result_df = result_rdd.toDF(output_schema)
return result_df
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ object DatabricksUtilities {
"interpret-community",
"numpy==1.22.4",
"unstructured==0.10.24",
"pytesseract"
"pytesseract",
)

def baseURL(apiVersion: String): String = s"https://$Region.azuredatabricks.net/api/$apiVersion/"
Expand All @@ -84,7 +84,8 @@ object DatabricksUtilities {
Map("maven" -> Map("coordinates" -> PackageMavenCoordinate, "repo" -> PackageRepository)),
Map("pypi" -> Map("package" -> "pytorch-lightning==1.5.0")),
Map("pypi" -> Map("package" -> "torchvision==0.14.1")),
Map("pypi" -> Map("package" -> "transformers==4.32.1")),
Map("pypi" -> Map("package" -> "transformers==4.48.0")),
Map("pypi" -> Map("package" -> "jinja2==3.1.0")),
Map("pypi" -> Map("package" -> "petastorm==0.12.0")),
Map("pypi" -> Map("package" -> "protobuf==3.20.3"))
).toJson.compactPrint
Expand All @@ -105,12 +106,15 @@ object DatabricksUtilities {
val CPUNotebooks: Seq[File] = ParallelizableNotebooks
.filterNot(_.getAbsolutePath.contains("Fine-tune"))
.filterNot(_.getAbsolutePath.contains("GPU"))
.filterNot(_.getAbsolutePath.contains("Language Model"))
.filterNot(_.getAbsolutePath.contains("Multivariate Anomaly Detection")) // Deprecated
.filterNot(_.getAbsolutePath.contains("Audiobooks")) // TODO Remove this by fixing auth
.filterNot(_.getAbsolutePath.contains("Art")) // TODO Remove this by fixing performance
.filterNot(_.getAbsolutePath.contains("Explanation Dashboard")) // TODO Remove this exclusion

val GPUNotebooks: Seq[File] = ParallelizableNotebooks.filter(_.getAbsolutePath.contains("Fine-tune"))
val GPUNotebooks: Seq[File] = ParallelizableNotebooks.filter { file =>
file.getAbsolutePath.contains("Fine-tune") || file.getAbsolutePath.contains("HuggingFace")
}

val RapidsNotebooks: Seq[File] = ParallelizableNotebooks.filter(_.getAbsolutePath.contains("GPU"))

Expand Down
2 changes: 1 addition & 1 deletion deep-learning/src/main/python/horovod_installation.sh
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ set -eu
# Install prerequisite libraries that horovod depends on
pip install pytorch-lightning==1.5.0
pip install torchvision==0.14.1
pip install transformers==4.32.1
pip install transformers==4.48.0
pip install petastorm>=0.12.0
pip install protobuf==3.20.3

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,12 @@
if _TRANSFORMERS_AVAILABLE:
import transformers

_TRANSFORMERS_EQUAL_4_32_1 = transformers.__version__ == "4.32.1"
if _TRANSFORMERS_EQUAL_4_32_1:
_TRANSFORMERS_EQUAL_4_48_0 = transformers.__version__ == "4.48.0"
if _TRANSFORMERS_EQUAL_4_48_0:
from transformers import AutoTokenizer
else:
raise RuntimeError(
"transformers should be == 4.32.1, found: {}".format(
"transformers should be == 4.48.0, found: {}".format(
transformers.__version__
)
)
Expand Down
Loading
Loading