Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Synthetic difference in differences #2095
feat: Synthetic difference in differences #2095
Changes from 49 commits
80762ec
2dbd448
1de7aa1
98a6659
29deccc
b7293c2
0eb6b62
5e93636
2c7a6a0
697b578
0aa9fc2
5660ace
b2d9477
ca354cc
37b138d
b02aa6f
e55a8ac
b76641b
1a2e320
03b8bbc
3bee3d7
5787e9e
faa1900
a7b6f20
0f37f60
aa6728a
c1eeaff
f6aaed6
b0326a7
813a68d
df296a6
280ab2d
638d9b4
6553653
864a04f
7c47d42
e60ee35
43f767f
076576e
394936e
be581ad
a3af20e
2e636e0
5b9ab17
c2d413f
af8c88e
666d1ed
5cc9027
f9bb83c
f1bf701
cb8fd47
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
technically now that we are 1.0 this is a breaking change, if you could deprecate and create new ones would appreciate it. To defend yourself against this, please consider makign any APIs you dont want to have to babysit private, private[ml], or protected
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This trait is shared between multiple estimators (DoubleML, SyntheticDiffInDiff, etc.), so I moved it to SharedParams.scala. The trait is still defined in the same package, so it shouldn't be breaking.