Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: factor accesstoken runtime-dependency wrapper out #2097

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

eisber
Copy link
Collaborator

@eisber eisber commented Oct 16, 2023

What changes are proposed in this pull request?

Factor accesstoken wrapper into a separate class so it can be consumed by others as well.

How is this patch tested?

Certified event tests

@eisber eisber requested a review from mhamilton723 as a code owner October 16, 2023 16:31
@github-actions
Copy link

Hey @eisber 👋!
Thank you so much for contributing to our repository 🙌.
Someone from SynapseML Team will be reviewing this pull request soon.

We use semantic commit messages to streamline the release process.
Before your pull request can be merged, you should make sure your first commit and PR title start with a semantic prefix.
This helps us to create release messages and credit you for your hard work!

Examples of commit messages with semantic prefixes:

  • fix: Fix LightGBM crashes with empty partitions
  • feat: Make HTTP on Spark back-offs configurable
  • docs: Update Spark Serving usage
  • build: Add codecov support
  • perf: improve LightGBM memory usage
  • refactor: make python code generation rely on classes
  • style: Remove nulls from CNTKModel
  • test: Add test coverage for CNTKModel

To test your commit locally, please follow our guild on building from source.
Check out the developer guide for additional guidance on testing your change.

@eisber eisber changed the title factor accesstoken runtime-dependency wrapper out feat: factor accesstoken runtime-dependency wrapper out Oct 16, 2023
@eisber
Copy link
Collaborator Author

eisber commented Oct 16, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov-commenter
Copy link

codecov-commenter commented Oct 16, 2023

Codecov Report

Merging #2097 (49df5da) into master (3fc47ae) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #2097      +/-   ##
==========================================
- Coverage   86.29%   86.27%   -0.03%     
==========================================
  Files         309      310       +1     
  Lines       16254    16254              
  Branches      833      826       -7     
==========================================
- Hits        14027    14023       -4     
- Misses       2227     2231       +4     
Files Coverage Δ
...napse/ml/logging/fabric/CertifiedEventClient.scala 36.84% <0.00%> (+9.39%) ⬆️
...crosoft/azure/synapse/ml/fabric/TokenLibrary.scala 0.00% <0.00%> (ø)

... and 4 files with indirect coverage changes

@eisber eisber enabled auto-merge (squash) October 16, 2023 19:11
@mhamilton723 mhamilton723 disabled auto-merge October 16, 2023 19:52
@eisber eisber enabled auto-merge (squash) October 16, 2023 19:53
@mhamilton723 mhamilton723 merged commit 83e199a into microsoft:master Oct 16, 2023
64 of 70 checks passed
@eisber eisber deleted the marcozo/access_token branch October 16, 2023 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants