Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add certified event feature categories #2109

Merged
merged 3 commits into from
Oct 26, 2023

Conversation

eisber
Copy link
Collaborator

@eisber eisber commented Oct 25, 2023

added certified event feature categories as discussed.

@github-actions
Copy link

Hey @eisber 👋!
Thank you so much for contributing to our repository 🙌.
Someone from SynapseML Team will be reviewing this pull request soon.

We use semantic commit messages to streamline the release process.
Before your pull request can be merged, you should make sure your first commit and PR title start with a semantic prefix.
This helps us to create release messages and credit you for your hard work!

Examples of commit messages with semantic prefixes:

  • fix: Fix LightGBM crashes with empty partitions
  • feat: Make HTTP on Spark back-offs configurable
  • docs: Update Spark Serving usage
  • build: Add codecov support
  • perf: improve LightGBM memory usage
  • refactor: make python code generation rely on classes
  • style: Remove nulls from CNTKModel
  • test: Add test coverage for CNTKModel

To test your commit locally, please follow our guild on building from source.
Check out the developer guide for additional guidance on testing your change.

@eisber eisber changed the title feature: add certified event feature categories feat: add certified event feature categories Oct 25, 2023
@eisber
Copy link
Collaborator Author

eisber commented Oct 25, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov-commenter
Copy link

codecov-commenter commented Oct 25, 2023

Codecov Report

Merging #2109 (46c5377) into master (2f31f74) will decrease coverage by 0.27%.
The diff coverage is 99.52%.

@@            Coverage Diff             @@
##           master    #2109      +/-   ##
==========================================
- Coverage   86.40%   86.14%   -0.27%     
==========================================
  Files         311      312       +1     
  Lines       16267    16292      +25     
  Branches      818      832      +14     
==========================================
- Hits        14056    14035      -21     
- Misses       2211     2257      +46     
Files Coverage Δ
...ynapse/ml/cognitive/anomaly/AnomalyDetection.scala 81.19% <100.00%> (ø)
...gnitive/anomaly/MultivariateAnomalyDetection.scala 90.71% <100.00%> (+0.61%) ⬆️
...re/synapse/ml/cognitive/bing/BingImageSearch.scala 89.28% <100.00%> (ø)
...crosoft/azure/synapse/ml/cognitive/face/Face.scala 81.37% <100.00%> (ø)
...ynapse/ml/cognitive/form/FormOntologyLearner.scala 90.19% <100.00%> (ø)
...ure/synapse/ml/cognitive/form/FormRecognizer.scala 84.04% <100.00%> (ø)
...e/synapse/ml/cognitive/form/FormRecognizerV3.scala 88.00% <100.00%> (ø)
...re/synapse/ml/cognitive/language/AnalyzeText.scala 95.17% <100.00%> (ø)
...pse/ml/cognitive/openai/OpenAIChatCompletion.scala 95.23% <100.00%> (ø)
...synapse/ml/cognitive/openai/OpenAICompletion.scala 93.75% <100.00%> (ø)
... and 100 more

... and 6 files with indirect coverage changes

@eisber
Copy link
Collaborator Author

eisber commented Oct 25, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

mhamilton723
mhamilton723 previously approved these changes Oct 25, 2023
@eisber
Copy link
Collaborator Author

eisber commented Oct 26, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mhamilton723 mhamilton723 merged commit 5c0b803 into microsoft:master Oct 26, 2023
67 of 68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants