-
Notifications
You must be signed in to change notification settings - Fork 836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: unit test break in TranslatorSuite #2111
Conversation
/azp run |
Hey @memoryz 👋! We use semantic commit messages to streamline the release process. Examples of commit messages with semantic prefixes:
To test your commit locally, please follow our guild on building from source. |
Azure Pipelines successfully started running 1 pipeline(s). |
...tive/src/test/scala/com/microsoft/azure/synapse/ml/cognitive/translate/TranslatorSuite.scala
Outdated
Show resolved
Hide resolved
...tive/src/test/scala/com/microsoft/azure/synapse/ml/cognitive/translate/TranslatorSuite.scala
Outdated
Show resolved
Hide resolved
…ive/translate/TranslatorSuite.scala
…ive/translate/TranslatorSuite.scala
...tive/src/test/scala/com/microsoft/azure/synapse/ml/cognitive/translate/TranslatorSuite.scala
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #2111 +/- ##
===========================================
- Coverage 83.96% 60.56% -23.40%
===========================================
Files 312 312
Lines 16292 16292
Branches 832 832
===========================================
- Hits 13679 9868 -3811
- Misses 2613 6424 +3811 |
…ive/translate/TranslatorSuite.scala
...tive/src/test/scala/com/microsoft/azure/synapse/ml/cognitive/translate/TranslatorSuite.scala
Outdated
Show resolved
Hide resolved
…ive/translate/TranslatorSuite.scala
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!!!
/azp run |
1 similar comment
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
What changes are proposed in this pull request?
Fixing a unit test break. The correct Chinese translation for "Hi, this is Synapse!" should be "嗨,我是Synapse!".
"这是突触" is a word-for-word translation of "this is synapse", not recognizing Synapse as a product name. Looks like the translation cognitive service fixed the issue.
How is this patch tested?
Does this PR change any dependencies?
Does this PR add a new feature? If so, have you added samples on website?
website/docs/documentation
folder.Make sure you choose the correct class
estimators/transformers
and namespace.DocTable
points to correct API link.yarn run start
to make sure the website renders correctly.<!--pytest-codeblocks:cont-->
before each python code blocks to enable auto-tests for python samples.WebsiteSamplesTests
job pass in the pipeline.