Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unit test break in TranslatorSuite #2111

Merged
merged 7 commits into from
Oct 27, 2023
Merged

Conversation

memoryz
Copy link
Contributor

@memoryz memoryz commented Oct 27, 2023

What changes are proposed in this pull request?

Fixing a unit test break. The correct Chinese translation for "Hi, this is Synapse!" should be "嗨,我是Synapse!".

"这是突触" is a word-for-word translation of "this is synapse", not recognizing Synapse as a product name. Looks like the translation cognitive service fixed the issue.

How is this patch tested?

  • I have written tests (not required for typo or doc fix) and confirmed the proposed feature/bug-fix/change works.

Does this PR change any dependencies?

  • No. You can skip this section.
  • Yes. Make sure the dependencies are resolved correctly, and list changes here.

Does this PR add a new feature? If so, have you added samples on website?

  • No. You can skip this section.
  • Yes. Make sure you have added samples following below steps.
  1. Find the corresponding markdown file for your new feature in website/docs/documentation folder.
    Make sure you choose the correct class estimators/transformers and namespace.
  2. Follow the pattern in markdown file and add another section for your new API, including pyspark, scala (and .NET potentially) samples.
  3. Make sure the DocTable points to correct API link.
  4. Navigate to website folder, and run yarn run start to make sure the website renders correctly.
  5. Don't forget to add <!--pytest-codeblocks:cont--> before each python code blocks to enable auto-tests for python samples.
  6. Make sure the WebsiteSamplesTests job pass in the pipeline.

@memoryz memoryz marked this pull request as ready for review October 27, 2023 05:42
@memoryz memoryz requested a review from mhamilton723 as a code owner October 27, 2023 05:42
@memoryz
Copy link
Contributor Author

memoryz commented Oct 27, 2023

/azp run

@github-actions
Copy link

Hey @memoryz 👋!
Thank you so much for contributing to our repository 🙌.
Someone from SynapseML Team will be reviewing this pull request soon.

We use semantic commit messages to streamline the release process.
Before your pull request can be merged, you should make sure your first commit and PR title start with a semantic prefix.
This helps us to create release messages and credit you for your hard work!

Examples of commit messages with semantic prefixes:

  • fix: Fix LightGBM crashes with empty partitions
  • feat: Make HTTP on Spark back-offs configurable
  • docs: Update Spark Serving usage
  • build: Add codecov support
  • perf: improve LightGBM memory usage
  • refactor: make python code generation rely on classes
  • style: Remove nulls from CNTKModel
  • test: Add test coverage for CNTKModel

To test your commit locally, please follow our guild on building from source.
Check out the developer guide for additional guidance on testing your change.

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov-commenter
Copy link

codecov-commenter commented Oct 27, 2023

Codecov Report

Merging #2111 (27ce208) into master (cc77eda) will decrease coverage by 23.40%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #2111       +/-   ##
===========================================
- Coverage   83.96%   60.56%   -23.40%     
===========================================
  Files         312      312               
  Lines       16292    16292               
  Branches      832      832               
===========================================
- Hits        13679     9868     -3811     
- Misses       2613     6424     +3811     

see 155 files with indirect coverage changes

@mhamilton723
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Collaborator

@mhamilton723 mhamilton723 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!!

@memoryz memoryz enabled auto-merge (squash) October 27, 2023 05:57
@mhamilton723
Copy link
Collaborator

/azp run

1 similar comment
@memoryz
Copy link
Contributor Author

memoryz commented Oct 27, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@memoryz memoryz merged commit cd43ee7 into microsoft:master Oct 27, 2023
@memoryz memoryz deleted the unittest branch October 27, 2023 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants