-
Notifications
You must be signed in to change notification settings - Fork 833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix bind port failed on spark yarn environment #2233
base: master
Are you sure you want to change the base?
Conversation
@coddderX please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2233 +/- ##
==========================================
- Coverage 84.43% 84.43% -0.01%
==========================================
Files 327 327
Lines 16773 16771 -2
Branches 1511 1530 +19
==========================================
- Hits 14162 14160 -2
Misses 2611 2611 ☔ View full report in Codecov by Sentry. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
try { | ||
taskCtx.networkTopologyInfo.localSocket.close() | ||
} catch { | ||
case e: Exception => log.warn("close local bind port socket failed ") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks like its a bit generic of a error, can we make it more specific so we dont catch other errors?
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Related Issues/PRs
Close #2230
What changes are proposed in this pull request?
When training in a yarn Spark environment, sometimes it may encounter port binding failure. This is because multiple Spark jobs might be running on the same machine, but the port binding does not occur simultaneously. For example, at 10:01:00, task 1 of JobA finds that port 10001 is available. Then all tasks in JobA find the port and close immediately, not until 10:03:00 does lightgbm bind to port 10001. At the same time, task 1 of Spark JobB finds port 1001 available at 10:02:00, then all tasks in JobB find the port and close immediately. However, until 10:04:00, lightgbm attempts to bind to port 10001, but the binding fails due to port conflict.
like issuse 2230
How is this patch tested?
Does this PR change any dependencies?
Does this PR add a new feature? If so, have you added samples on website?
website/docs/documentation
folder.Make sure you choose the correct class
estimators/transformers
and namespace.DocTable
points to correct API link.yarn run start
to make sure the website renders correctly.<!--pytest-codeblocks:cont-->
before each python code blocks to enable auto-tests for python samples.WebsiteSamplesTests
job pass in the pipeline.