Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: NoSuchMethodError from breeze in interpretibility notebook when running in Fabric 3.3 pool #2284

Merged
merged 3 commits into from
Sep 12, 2024

Conversation

memoryz
Copy link
Contributor

@memoryz memoryz commented Sep 10, 2024

Related Issues/PRs

#2188
#2004

What changes are proposed in this pull request?

Bug fix: in Fabric Spark 3.3 runtime, the preinstalled breeze version seems to cause NoSuchMethodError error when running Kernel SHAP code. This change specifies the right breeze version to force Spark runtime to use the correct version of breeze.

How is this patch tested?

Tested in Fabric Spark 3.3 runtime.

Does this PR change any dependencies?

  • No. You can skip this section.
  • Yes. Make sure the dependencies are resolved correctly, and list changes here.

Does this PR add a new feature? If so, have you added samples on website?

  • No. You can skip this section.
  • Yes. Make sure you have added samples following below steps.
  1. Find the corresponding markdown file for your new feature in website/docs/documentation folder.
    Make sure you choose the correct class estimators/transformers and namespace.
  2. Follow the pattern in markdown file and add another section for your new API, including pyspark, scala (and .NET potentially) samples.
  3. Make sure the DocTable points to correct API link.
  4. Navigate to website folder, and run yarn run start to make sure the website renders correctly.
  5. Don't forget to add <!--pytest-codeblocks:cont--> before each python code blocks to enable auto-tests for python samples.
  6. Make sure the WebsiteSamplesTests job pass in the pipeline.

@memoryz
Copy link
Contributor Author

memoryz commented Sep 10, 2024

/azp run

Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@mhamilton723
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@mhamilton723
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov-commenter
Copy link

codecov-commenter commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.91%. Comparing base (82ad01a) to head (5a75cb4).

Additional details and impacted files
@@             Coverage Diff              @@
##           spark3.3    #2284      +/-   ##
============================================
+ Coverage     80.10%   80.91%   +0.81%     
============================================
  Files           327      327              
  Lines         16619    16619              
  Branches        855      855              
============================================
+ Hits          13312    13447     +135     
+ Misses         3307     3172     -135     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mhamilton723 mhamilton723 merged commit a583482 into microsoft:spark3.3 Sep 12, 2024
57 of 64 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]NoSuchMethodError breeze.linalg.SliceVector [BUG] Jupyter notebook execution behaving randomly
4 participants