Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Global Param Object #2306

Closed
wants to merge 7 commits into from

Conversation

sss04
Copy link
Contributor

@sss04 sss04 commented Nov 4, 2024

Related Issues/PRs

#xxx

What changes are proposed in this pull request?

Adding a GlobalParamObject allowing users to set fields like "DeploymentName" only once and for it to be used everywhere.

Introduces HasGlobalParams, containing getters for these new Global Params.

How is this patch tested?

  • I have written tests (not required for typo or doc fix) and confirmed the proposed feature/bug-fix/change works.

Does this PR change any dependencies?

  • No. You can skip this section.
  • Yes. Make sure the dependencies are resolved correctly, and list changes here.

Does this PR add a new feature? If so, have you added samples on website?

  • No. You can skip this section.
  • Yes. Make sure you have added samples following below steps.
  1. Find the corresponding markdown file for your new feature in website/docs/documentation folder.
    Make sure you choose the correct class estimators/transformers and namespace.
  2. Follow the pattern in markdown file and add another section for your new API, including pyspark, scala (and .NET potentially) samples.
  3. Make sure the DocTable points to correct API link.
  4. Navigate to website folder, and run yarn run start to make sure the website renders correctly.
  5. Don't forget to add <!--pytest-codeblocks:cont--> before each python code blocks to enable auto-tests for python samples.
  6. Make sure the WebsiteSamplesTests job pass in the pipeline.

@sss04 sss04 requested a review from mhamilton723 as a code owner November 4, 2024 18:19
@sss04 sss04 assigned sss04 and unassigned sss04 Nov 4, 2024
}
}

def getGlobalServiceParamVector[T](p: ServiceParam[T]): T= { //TODO: should return a string
Copy link
Collaborator

@mhamilton723 mhamilton723 Nov 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this perhaps should return String as it should be asking about the other side of the service param the name of the column

@sss04 sss04 changed the title Global Param Object feat: Global Param Object Nov 5, 2024
…sserts to type check Params vs Service Params. Added more tests. Tests pass!
@sss04 sss04 closed this Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants