Skip to content
This repository has been archived by the owner on Oct 12, 2022. It is now read-only.

Update Basic Types.md #1268

Closed
wants to merge 1 commit into from
Closed

Conversation

baldm0mma
Copy link

Text format didn't to appear to be within the template string itself. Found this issue on the typescript website when searching the docs. I have created an issue which this will fix => Formatting issue for String type docs in Basic Types.md #1267.

Fixes #

Text format didn't to appear to be within the template string itself.
Copy link
Contributor

@johnjago johnjago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see what you mean about the text not appearing to be within the template string, but template strings interpret everything literally. Therefore, the additional spaces that you added will appear when the string is printed.

If we were to console.log(sentence), this would be the output:

Hello, my name is Bob Bobbington.

    I'll be 38 years old next month.

But we most likely want this:

Hello, my name is Bob Bobbington.

I'll be 38 years old next month.

@orta
Copy link
Contributor

orta commented Jan 15, 2020

Thanks for the PR @baldm0mma - but I'm with @johnjago on this one, the whitespace is important here and so I'm going to close the PR

Thanks for thinking about improving the docs and making the PR though!

@orta orta closed this Jan 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants