Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor HTTP Files and add Image Generation #45

Merged

Conversation

martinpeck
Copy link
Member

@martinpeck martinpeck commented Sep 11, 2024

This PR refactors the .http files so that...

  • one file per API (to reduce clutter/length of files)
  • add "REST Client environments" so that its easy to point the HTTP files at either local or azure
  • add new image gen calls to the suite of HTTP files, and the required env var to support this

Closes #47

@martinpeck martinpeck changed the title Add Support for Image Endpoint Refactor HTTP Files and add Image Generation Sep 12, 2024
@martinpeck martinpeck marked this pull request as ready for review September 12, 2024 15:02
@martinpeck
Copy link
Member Author

martinpeck commented Sep 12, 2024

There's some overlap in what I've changed here, and what @hannesne has updates/change in the docs related to "getting started".

So...my suggestion is merge #46 first, and assume any approval of this PR includes fixing the docs up first.

@martinpeck
Copy link
Member Author

This would close #47

Copy link
Collaborator

@stuartleeks stuartleeks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - a couple of minor typos.

This is definitely cleaner than the previous approach - thanks

docs/config.md Outdated Show resolved Hide resolved
@stuartleeks stuartleeks force-pushed the mpeck/13-add-image-gen-endpoint branch from cd13bdc to 2e97a1c Compare September 16, 2024 17:24
@stuartleeks stuartleeks enabled auto-merge (squash) September 16, 2024 17:25
@stuartleeks stuartleeks merged commit da8704e into microsoft:main Sep 16, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suggestion: Move HTTP files into Subfolder and Refactor
2 participants