-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Throttle API Calls #2283
Merged
Merged
Throttle API Calls #2283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2283 +/- ##
===========================================
- Coverage 33.88% 12.60% -21.29%
===========================================
Files 87 89 +2
Lines 9422 9547 +125
Branches 2011 2194 +183
===========================================
- Hits 3193 1203 -1990
- Misses 5961 8327 +2366
+ Partials 268 17 -251
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jackgerrits
had a problem deploying
to
openai1
September 25, 2024 15:40
— with
GitHub Actions
Failure
jackgerrits
had a problem deploying
to
openai1
September 25, 2024 15:40
— with
GitHub Actions
Failure
jackgerrits
had a problem deploying
to
openai1
September 25, 2024 15:40
— with
GitHub Actions
Failure
jackgerrits
had a problem deploying
to
openai1
September 25, 2024 15:40
— with
GitHub Actions
Failure
jackgerrits
had a problem deploying
to
openai1
September 25, 2024 15:40
— with
GitHub Actions
Failure
jackgerrits
had a problem deploying
to
openai1
September 25, 2024 15:40
— with
GitHub Actions
Failure
jackgerrits
had a problem deploying
to
openai1
September 25, 2024 15:40
— with
GitHub Actions
Failure
jackgerrits
had a problem deploying
to
openai1
September 25, 2024 15:40
— with
GitHub Actions
Failure
jackgerrits
had a problem deploying
to
openai1
September 25, 2024 15:40
— with
GitHub Actions
Failure
jackgerrits
approved these changes
Sep 25, 2024
jackgerrits
had a problem deploying
to
openai1
September 25, 2024 15:40
— with
GitHub Actions
Failure
jackgerrits
had a problem deploying
to
openai1
September 25, 2024 15:40
— with
GitHub Actions
Failure
jackgerrits
had a problem deploying
to
openai1
September 25, 2024 15:40
— with
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR introduces a naive time-based rate limiter to throttle API calls more effectively. While the existing FAQ suggests using
max_retries
for rate limit errors, this approach can be unreliable and requires fine-tuning. The new rate limiter provides a direct solution to control the flow of API requests, improving the overall reliability.The user can now specify the
api_rate_limit
in the config list.Related issue number
Checks