Ability to add MessageTransforms to the GroupChat's Select Speaker nested chat (speaker_selection_method='auto') #2719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victordibia
pushed a commit
that referenced
this pull request
Aug 28, 2024
…sted chat (speaker_selection_method='auto') (#2719) * Initial commit with ability to add transforms to GroupChat * Added tests * Tidy up * Tidy up of variable names and commented out test * Tidy up comment * Update import to relative * Added documentation topic for transform messages for speaker selection. * Added handling of non-core module, transforms, in groupchat * Adjusted parameter if module not loaded. * Updated groupchat test which failed during CI/CD --------- Co-authored-by: Li Jiang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides the ability to add MessageTransforms to the nested select speaker chat that occurs in a GroupChat when the speaker selection method is 'auto'. The MessageTransforms apply only to the messages within that nested select speaker chat (and not to the broader GroupChat chat).
The GroupChat constructor has a new, optional, parameter called
select_speaker_auto_message_transformsthat takes in aMessageTransformsobject, orNone.Within GroupChat, the provided MessageTransforms object will be assigned to
self._auto_message_transformsand used within_auto_select_speakeranda_auto_select_speaker.The nested select speaker chat has two agents,
checking_agentandspeaker_selection_agentand the MessageTransforms are added to thespeaker_selection_agentas that is the agent that utilises the LLM.cc @Nathan-Intergral, @WebsheetPlugin
Why are these changes needed?
These changes enable greater control and flexibility of messages for speaker selection. Particularly useful for non-OpenAI models with limited context / reasoning ability.
Related issue number
Addresses #2499.
Addresses part of #2583.
I will carry forward other suggested changes in #2583 -
select_speaker_auto_compression,select_speaker_auto_token_limit,select_speaker_auto_token_limit- it is useful to have these simple methods to enable message transforms without the developer having to create them, however as I test the effectiveness of the select speaker method I need more time to think through what would be most beneficial.Checks