Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

async user hook support added #3583

Merged
merged 2 commits into from
Sep 30, 2024
Merged

Conversation

robraux
Copy link
Contributor

@robraux robraux commented Sep 30, 2024

Why are these changes needed?

  • Async user hooks are added to mirror library async support in other areas.
  • Adds async tests for all hook types, adds sync tests for 2 untested hook types.
  • Adds hook sync vs. async checks on add hook, with warning for mismatch

Related issue number

Closes/replaces: #1845

Checks

@robraux
Copy link
Contributor Author

robraux commented Sep 30, 2024

Tagging you @rickyloynd-microsoft, @gagb, and @cemtu as you commented previously on the hung PR #1845

Copy link
Collaborator

@ekzhu ekzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants