-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add UserProxyAgent in AgentChat API #4255
Conversation
I think it may be worth checking if the cancellation token is set in the input function, so user who was asked to provide the input can get feedback when their input was cancelled. The user what was asked to provide the input may not be the user that runs the application. So having the cancellation token as part of the input function's argument is good.
Not necessary for now, right? |
@ekzhu , @husseinmozannar . |
I will do my best to take a look today, worst case tomorrow/sunday |
python/packages/autogen-agentchat/src/autogen_agentchat/agents/_user_proxy_agent.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested works well!
While current tutorial shows how to create custom agents, a UserProxyAgent seems to be a common preset and it would be good to have an implementation that can be easily reused as part of the api instead of apps having multiple implementations (e.g., AGS) . This PR is meant to start a design conversation around this.
This PR does the following:
input_func
in constructor that defaults to consoleinput
if nothing is passed.input_func
gets called when the UserProxyAgent gets a message, and returns a stringTo be done:
Why are these changes needed?
Provide some standard/guidance around creating a UserProxyAgent.
Related issue number
Related to #3614
Checks