Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix console warnings #249

Merged
merged 2 commits into from
Nov 2, 2023
Merged

Fix console warnings #249

merged 2 commits into from
Nov 2, 2023

Conversation

thivy
Copy link
Contributor

@thivy thivy commented Nov 2, 2023

This pull request includes a variety of changes to improve the structure and styling of the chat UI, including modifying components to use different elements, importing components from different modules, and refactoring code. The most important changes include modifying the ChatFileSlider component to use a div instead of SheetDescription, modifying the CitationSlider component to improve code structure and styling, and refactoring the Markdown component to import the Paragraph component from a different module.

Main interface changes:

  • src/features/chat/chat-ui/chat-file/chat-file-slider.tsx: Modified ChatFileSlider component to use a div instead of SheetDescription, and imported Button component from a different module. [1] [2]
  • src/features/chat/chat-ui/markdown/citation-slider.tsx: Modified CitationSlider component to improve code structure and styling, including using asChild prop instead of wrapping Button component, removing SheetDescription component, and importing Button component from ui/button module. [1] [2] [3]
  • src/components/markdown/config.tsx: Modified citationConfig object to include paragraph node and imported citation tag from chat-ui/markdown/citation module.

Refactoring changes:

  • src/components/markdown/paragraph.tsx: Defined a new Paragraph component with a div element that renders children and className props. Defined a new paragraph object with a render property that references the Paragraph component.
  • src/components/markdown/markdown.tsx: Refactored the Markdown component to import the Paragraph component from a different module and modify the components property of the Markdoc.renderers.react function. [1] [2]

Other changes:

  • src/next.config.js: Removed the experimental object from next.config.js.
  • src/app/layout.tsx: Removed the light class from the className prop of the html element in RootLayout.
  • src/features/chat/chat-ui/markdown/citation-action.tsx: Imported the simpleSearch function from a different module using a relative path.
  • src/app/change-log/page.tsx: Moved import of Markdown component from chat/markdown to components/markdown.
  • src/features/chat/chat-ui/markdown/citation.tsx: Modified the citation object to include the render property and remove the tags property. Removed the Config import and citationConfig object, and modified the Props interface to remove the items property. [1] [2]
  • src/features/chat/chat-ui/chat-input/chat-input.tsx: Modified ChatInput container element's className prop to remove the items-end class.
  • src/components/chat/chat-row.tsx: Updated import statement to use Markdown component from correct module.

@davidxw davidxw merged commit d05cda2 into main Nov 2, 2023
3 checks passed
Sandeep-FED pushed a commit to Sandeep-FED/azurechat that referenced this pull request Jun 14, 2024
Sandeep-FED pushed a commit to Sandeep-FED/azurechat that referenced this pull request Jun 14, 2024
jnxjent pushed a commit to jnxjent/azurechat that referenced this pull request Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants