-
Notifications
You must be signed in to change notification settings - Fork 549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changing name produced for cvm and marketplace images #10403
base: 3.0-dev
Are you sure you want to change the base?
Conversation
6f6166f
to
4f9d588
Compare
Is there a need for the |
Good point. I synced with Jon before about renaming it as well. Renaming it would require updating our infrastructure as currently some build, publish and possibly test infrastructure code is used to having |
…to mbykhovtsev/image-gen-tweak
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-static
subpackages, etc.) have had theirRelease
tag incremented../cgmanifest.json
,./toolkit/scripts/toolchain/cgmanifest.json
,.github/workflows/cgmanifest.json
)./LICENSES-AND-NOTICES/SPECS/data/licenses.json
,./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md
,./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON
)*.signatures.json
filessudo make go-tidy-all
andsudo make go-test-coverage
passSummary
Changes the naming pattern for cvm image to use
cblmariner-gen2-cvm.vhd
format to be descriptive and uniform with how other image types are nameChange Log
cblmariner-gen2-cvm.vhd
format to be descriptive and uniform with how other image types are nameDoes this affect the toolchain?
NO