Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add '-a' option to build-mic-container.sh for arch selection. #10639

Open
wants to merge 2 commits into
base: 3.0-dev
Choose a base branch
from

Conversation

liulanze
Copy link
Contributor

@liulanze liulanze commented Oct 6, 2024

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

What does the PR accomplish, why was it needed?
Add '-a' option to build-mic-container.sh for arch selection.
MIC ARM64 arch binary build needs this PR commit.

We still need:

  • Another Dockerfile probably named Dockerfile.mic-container.arm64, change the base image from core 2.0 to core 2.0 arm64. However, this probably needs to create a new tag for core arm64 since for now it does not have a stable tag for arm64 arch.
  • The package dependency grub2-pc does NOT support arm64, we need to find a substitution.
  • GPG key issue.
Does this affect the toolchain?

NO

Test Methodology
  • Pipeline build id: Local build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant