Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libsoup: add patches for CVE-2024-52530, CVE-2024-52531, CVE-2024-52532 #11108

Open
wants to merge 3 commits into
base: fasttrack/3.0
Choose a base branch
from

Conversation

trungams
Copy link
Member

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

What does the PR accomplish, why was it needed?
Add patches for CVE-2024-52530, CVE-2024-52531, CVE-2024-52532 affecting libsoup

Does this affect the toolchain?

NO

Links to CVEs

Signed-off-by: Thien Trung Vuong <[email protected]>
Copy link
Contributor

@mbykhovtsev-ms mbykhovtsev-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems some of the patches are not applying cleanly. You might need to tweak them

@trungams
Copy link
Member Author

@mbykhovtsev-ms The patches are fine, it's the patch command (%autosetup) that was missing -p1 flag initially so it could not apply. The most recent pipeline run was cancelled for some reason. Should I rerun it?

@mbykhovtsev-ms
Copy link
Contributor

@mbykhovtsev-ms The patches are fine, it's the patch command (%autosetup) that was missing -p1 flag initially so it could not apply. The most recent pipeline run was cancelled for some reason. Should I rerun it?

Ah, that make sense. Yes, we need to re-run it to verify it does not break any other packages that depend on this. I restarted it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants