Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh: Upgrade to 2.62.0 to address HIGH CVE-2024-52308 #11152

Open
wants to merge 3 commits into
base: fasttrack/3.0
Choose a base branch
from

Conversation

vinceaperri
Copy link
Contributor

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

Upgrades gh to 2.62.0 to address CVE-2024-52308

Change Log
  • Upgrade gh to 2.62.0
  • Add gh patch to fix fasle negative when running tests as root
  • Add helper script to generate gh source and vendor tarballs and update signatures
Does this affect the toolchain?

NO

Links to CVEs
Test Methodology
  • Pipeline build id: 679171

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe our automation might be expective certain arguments to be passed such as srcTarball, outFolder and pkgVersion, I believe the file might also need to be called generate-tarball.sh. Would you be able to confirm that with Nicolas Guibourge?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vinceaperri vinceaperri changed the title gh: Upgrade to 2.62.0 to address CVE-2024-52308 gh: Upgrade to 2.62.0 to address HIGH CVE-2024-52308 Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants