Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove ms-rest package #4523

Merged
merged 8 commits into from
Aug 18, 2023
Merged

fix: Remove ms-rest package #4523

merged 8 commits into from
Aug 18, 2023

Conversation

ceciliaavila
Copy link
Collaborator

#minor

Description

This PR removes the ms-rest package to avoid using request dependency due to its vulnerability issue.

Specific Changes

  • Replaced ms-rest package with @azure/ms-rest-js for use of stripRequest and stripResponse methods and serializer class.
  • Added HttpOperationResponse models in tools resources.
  • Added addSerializationMixin method into ResourceManagementClient class.
  • Removed unnecessary .d.ts files.

Testing

The following image shows the botframework-connector tests, which use bb tools, running successfully.
image

@ceciliaavila ceciliaavila requested a review from a team as a code owner August 18, 2023 14:28
@coveralls
Copy link

coveralls commented Aug 18, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 5903812882

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.852%
Totals Coverage Status
Change from base Build 5903299207: 0.0%
Covered Lines: 20134
Relevant Lines: 22485
💛 - Coveralls

@tracyboehrer tracyboehrer merged commit 06d7883 into main Aug 18, 2023
@tracyboehrer tracyboehrer deleted the southworks/update/remove-ms-rest branch August 18, 2023 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tracyboehrer tracyboehrer tracyboehrer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ceciliaavila @coveralls @tracyboehrer @JhontSouth