Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delay load graph engine dll #1257

Merged
merged 1 commit into from
Jun 2, 2020

Conversation

joseartrivera
Copy link
Contributor

Partially addresses #209

Description of the changes:

  • Delay load graph engine DLLs until the code needs them.

How changes were validated:

  • Manual tests, checking modules in VS to verify that the omsaut.dll and graphengine.dll are loaded only when the user enters graphing mode

@mcooley mcooley self-assigned this Jun 2, 2020
@mcooley
Copy link
Member

mcooley commented Jun 2, 2020

@joseartrivera code looks good to me. Do we have before/after perf numbers for this change?

@joseartrivera
Copy link
Contributor Author

@joseartrivera code looks good to me. Do we have before/after perf numbers for this change?

Last I checked the change in perf is not perceivable on my machine but I think this is a good change to have anyway for slower machines and reducing the amount loaded in memory.

@mcooley
Copy link
Member

mcooley commented Jun 2, 2020

OK, I figured the launch latency improvement would be small. Working set reduction seems like a worthy goal.

@joseartrivera joseartrivera merged commit 09391d8 into microsoft:master Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants