Work around a currency service defect for localization #2302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guominrui
reviewed
Feb 21, 2025
hanzhang54
reviewed
Feb 21, 2025
hanzhang54
approved these changes
Feb 21, 2025
tian-lt
changed the title
tian-lt
added a commit
to tian-lt/calculator
that referenced
this pull request
Feb 21, 2025
* always use `lang-region` for localization * language code may have a single segment
tian-lt
added a commit
that referenced
this pull request
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
The currency service seems have changed their fallback rules for unrecognized language code about Chinese, which causes users who selected zh-Hant-TW get simplified Chinese content in the currency converter.
Fix
Regarding the standard of BCP47, manually construct a two-segment language code (e.g. zh-TW) from multi-segment language code (e.g. zh-Hant-TW) to ensure the localization service can recognize the language code and provide the correct content.