Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to fix Linux build #305

Merged
merged 2 commits into from
Jul 19, 2024
Merged

Attempt to fix Linux build #305

merged 2 commits into from
Jul 19, 2024

Conversation

wravery
Copy link
Contributor

@wravery wravery commented Jul 19, 2024

I haven't been able to reproduce the same build break locally, but this ought to fix the error that was reported in #301.

@wravery
Copy link
Contributor Author

wravery commented Jul 19, 2024

I was finally able to reproduce the original build break, and it happened with or without the first commit. I also needed to avoid constructing a temporary TypeData value on the stack just to assign it to _data. Instead, it should assign the std::variant option type directly to _data, which has already been constructed with a NullData in the constructor's initializer list.

@wravery wravery merged commit aa02e66 into microsoft:main Jul 19, 2024
13 checks passed
@wravery wravery deleted the fix-301 branch July 19, 2024 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant