Large file support on 32bit platforms #1636
Open
+97
−123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- on 32bit platforms size_t is not enough to support files with size greater than 4GB.
|
|
|
I don't have a lot of time to review this for correctness on all our platforms and so would like tests, in particular for every data value widened from size_t to int64_t I'd like to see a test that results in that data value actually exceeding UINT32_MAX. I already spotted several instances where you're using int64_t as an offset into an array, or passing it to memcpy. I'd suggest using truncate(on linux) or SetEndOfFile (on windows) to create a very large file, and then write some known data to a few pages in the very large region. |
barcharcraz
reviewed
Aug 9, 2021
| @@ -468,7 +468,7 @@ size_t _getn_fsb(Concurrency::streams::details::_file_info* info, | |||
| if (static_cast<int>(read) > 0) | |||
| { | |||
| auto copy = (std::min)(read, byteCount); | |||
| auto bufoff = fInfo->m_rdpos - fInfo->m_bufoff; | |||
| auto bufoff = static_cast<size_t>(fInfo->m_rdpos - fInfo->m_bufoff); | |||
There was a problem hiding this comment.
this is concerning to me since it seems like it could cause truncation on a size passed to memcpy, and may need a validation check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
greater than 4GB.