Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix overflow exception when serializing #1746

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

25077667
Copy link

@25077667 25077667 commented Mar 9, 2023

When the MSB of the initial wchar_t is set, the lowSurrogate would be inferred to be "unsigned".
The if statement would be triggered, and the exception "UTF-16 string has invalid low surrogate" would be thrown.

This needs to be fixed by making the type "signed" and then comparing it to the integer values of the specified constants.

@25077667
Copy link
Author

25077667 commented Mar 9, 2023

You could also refer to:
The wchar_t type is defined by MIDL as an unsigned short(16-bit) data object [1].

Type wchar_­t is a distinct type that has an implementation-defined signed or unsigned integer type as its underlying type [2].

[1] https://learn.microsoft.com/en-us/windows/win32/midl/wchar-t
[2] https://eel.is/c++draft/basic.types#basic.fundamental-8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants