This repository was archived by the owner on Mar 7, 2025. It is now read-only.
Handle properly non-ascii values in credentials #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Aha! Years ago I had the hardest time with Outlook on Mac, finally figured it out it was a UTF encoding bug. Thanks for fixing this @abyss638, I hope it gets merged and released soon. Thanks so much for making this opensource btw, very useful! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #9
macOs keychain CLI returns non-ascii values as Hex value + escaped string. The change converts the hex value to UTF-8 Java string to handle properly non-ascii user / password values in credentials.
Special characters are now also supported for password values.