Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[logging] Enhancement: Turn on more log details #1459

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Conversation

iyzhang
Copy link
Contributor

@iyzhang iyzhang commented Nov 14, 2024

This PR turns on more details in our logging framework including timestamps, line numbers and thread ID. To help with the thread ID usefulness, I've also updated our unit tests with thread names.

@iyzhang iyzhang requested a review from anandbonde November 14, 2024 22:54
@iyzhang iyzhang self-assigned this Nov 14, 2024
Copy link
Contributor

@anandbonde anandbonde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Copy link

libos = catpowder
commit id = da925b6

collapsed_stack num_calls cycles_per_call nanoseconds_per_call percent_time
bgc::inetstack::poll_recv;inetstack::layer4_endpoint::poll_once 19274351.77 702.77 299.15 86.18
bgc::inetstack::poll_recv 9637175.88 1632.77 695.07 53.98
bgc::inetstack::tcp::established::background 16570.27 2120.16 894.89 0.32
bgc::inetstack::tcp::established::background;tcp::established::background::acknowledger 16570.27 326.82 140.54 14.14
bgc::inetstack::tcp::established::background;tcp::established::background::receiver 16561.61 742.68 311.01 30.48
bgc::inetstack::tcp::established::background;tcp::established::background::retransmitter 16532.66 327.80 139.06 18.18
bgc::inetstack::tcp::established::background;tcp::established::background::sender 16490.71 929.19 385.35 14.22
ioc::network::libos::pop 9031.47 495.17 210.24 0.05
ioc::network::libos::push;inetstack::push 8762.80 6134.39 2658.06 2.22
demikernel::sgafree 8749.94 122.03 51.58 0.01
ioc::network::libos::push 8073.74 33537304.32 15070196.41 41.20
demikernel::push 8073.74 646.75 276.66 0.05
demikernel::sgaalloc 6504.83 150.14 65.40 0.02
demikernel::pop 6035.94 705.12 298.02 0.04
bgc::inetstack::poll_recv;inetstack::poll_bg_work::for::for 5279.31 656.73 280.71 0.89
ioc::network::libos::pushto 703.67 5294.03 2302.49 2.37
ioc::network::libos::pushto;inetstack::push 703.67 4742.68 2062.69 89.66
demikernel::pushto 703.67 631.46 275.18 0.27
bgc::inetstack::poll_recv;inetstack::poll_bg_work::for::for;udp::receive 221.33 235.14 99.50 60.51
ioc::network::libos::close 47.77 6542.38 2803.29 0.09
bgc::passive_listening::poll 43.50 45660.19 19074.37 0.04
ioc::network::libos::connect 41.86 74965.32 31974.79 1.19
bgc::inetstack::tcp::passiveopen::background 41.86 31048.61 13034.36 0.02
ioc::network::libos::accept 38.21 4494.14 1891.34 0.00
demikernel::async_close 32.50 909.05 376.08 0.01
demikernel::accept 21.86 1716.40 716.94 0.00
demikernel::connect 20.93 4122.60 1816.57 0.02
demikernel::socket 10.30 4525.62 1934.63 0.00
bgc::inetstack::arp::background 6.37 1955.20 826.52 0.00
bgc::inetstack::poll_recv;inetstack::poll;inetstack::layer4_endpoint::poll_once 2.00 5865.10 2505.08 82.81
bgc::inetstack::icmp::background 1.03 3127.08 1331.25 0.00
demikernel::new 1.00 93965413.67 39913451.28 18.68
demikernel::bind 1.00 25368.31 10752.87 0.00
bgc::inetstack::poll_recv;inetstack::poll 1.00 14102.23 6018.66 0.04
demikernel::listen 1.00 9742.71 4091.19 0.00
demikernel::close 0.00 nan nan 0.00

Copy link

libos = catnap
commit id = da925b6

collapsed_stack num_calls cycles_per_call nanoseconds_per_call percent_time
bgc::catnap::transport::epoll 13329635.56 2069.78 896.00 33.08
demikernel::sgafree 11535.53 73.81 31.54 0.05
demikernel::sgaalloc 11282.42 129.06 55.69 0.11
ioc::network::libos::push;catnap::linux::transport::push 9066.12 709.95 310.73 4.35
ioc::network::libos::push 8800.49 16580.65 7225.03 7.00
demikernel::push 8800.49 538.82 234.09 0.16
ioc::network::libos::pop;catnap::linux::transport::pop 8023.05 390.91 168.09 3.98
ioc::network::libos::pop 7814.60 18416328.78 8239914.34 23.99
demikernel::pop 7814.60 535.26 228.72 0.13
ioc::network::libos::pushto 586.00 7528.58 3365.27 23.67
demikernel::pushto 586.00 464.18 207.53 1.50
ioc::network::libos::pushto;catnap::linux::transport::push 586.00 442.35 197.75 5.89
demikernel::async_close 32.50 968.60 379.42 0.01
ioc::network::libos::connect 24.95 6624329.85 2859697.07 29.18
ioc::network::libos::connect;catnap::linux::transport::connect 24.95 77585.62 33714.71 2.26
demikernel::connect 24.95 2116.21 938.66 0.01
ioc::network::libos::close 18.35 25069.28 10828.05 0.06
ioc::network::libos::close;catnap::linux::transport::close 18.35 23813.96 10281.88 95.03
ioc::network::libos::accept 15.42 915812910.29 391654198.66 44.23
demikernel::accept 15.42 1568.06 672.09 0.00
ioc::network::libos::accept;catnap::linux::transport::accept 15.39 4780.72 2060.28 0.00
demikernel::socket 9.50 156617.72 68816.77 0.30
demikernel::socket;catnap::linux::transport::socket 9.50 153764.93 67571.42 96.11
demikernel::new 1.00 264513.56 113593.54 0.13
demikernel::bind 1.00 29815.35 12811.41 0.01
demikernel::bind;catnap::linux::transport::bind 1.00 25194.40 10827.50 84.32
demikernel::listen 1.00 15882.08 6797.35 0.00
demikernel::listen;catnap::linux::transport::listen 1.00 14698.97 6292.10 92.54
demikernel::close 0.00 nan nan 0.00

Copy link

libos = catnip
commit id = da925b6

collapsed_stack num_calls cycles_per_call nanoseconds_per_call percent_time
bgc::inetstack::poll_recv;inetstack::layer4_endpoint::poll_once 29426272.93 340.33 147.96 75.94
bgc::inetstack::poll_recv;inetstack::layer4_endpoint::poll_once;catnip::runtime::receive 29426272.93 197.31 85.72 58.18
bgc::inetstack::poll_recv 14713136.47 899.75 391.30 34.76
bgc::inetstack::tcp::established::background 16573.02 1488.59 624.69 0.16
bgc::inetstack::tcp::established::background;tcp::established::background::acknowledger 16573.02 299.99 125.16 16.41
bgc::inetstack::tcp::established::background;tcp::established::background::receiver 16562.73 460.31 190.04 28.41
bgc::inetstack::tcp::established::background;tcp::established::background::retransmitter 16531.48 292.49 124.75 19.74
bgc::inetstack::tcp::established::background;tcp::established::background::sender 16489.23 318.36 127.34 9.54
ioc::network::libos::pop 9093.76 406.59 174.83 0.02
demikernel::sgafree 8874.83 96.17 41.57 0.01
ioc::network::libos::push;inetstack::push 8762.80 2092.13 931.79 0.65
ioc::network::libos::push;inetstack::push;catnip::runtime::transmit 8762.80 348.68 153.79 15.81
ioc::network::libos::push 8073.74 33411655.73 12971376.86 27.21
demikernel::push 8073.74 761.21 328.16 0.04
demikernel::sgaalloc 6642.17 149.56 64.05 0.01
demikernel::pop 6100.90 636.72 272.55 0.02
bgc::inetstack::poll_recv;inetstack::poll_bg_work::for::for 4469.92 727.11 312.06 1.42
ioc::network::libos::pushto 2910.00 1310.86 648.13 0.11
ioc::network::libos::pushto;inetstack::push 2910.00 685.21 339.74 52.52
demikernel::pushto 2910.00 481.43 239.26 0.04
ioc::network::libos::pushto;inetstack::push;catnip::runtime::transmit 2910.00 230.69 114.23 33.63
bgc::inetstack::poll_recv;inetstack::poll_bg_work::for::for;udp::receive 1347.33 225.05 105.54 69.06
ioc::network::libos::close 49.47 6099.23 2625.27 0.01
ioc::network::libos::connect 41.86 68348.19 28834.20 0.13
bgc::inetstack::tcp::passiveopen::background 41.86 37711.92 16601.22 0.02
ioc::network::libos::connect;catnip::runtime::transmit 41.86 5814.64 2522.29 16.01
bgc::passive_listening::poll 39.71 58032.51 25182.61 0.02
ioc::network::libos::accept 38.18 2445.63 1080.41 0.00
demikernel::async_close 32.50 793.00 309.85 0.00
demikernel::accept 21.86 2047.05 917.38 0.00
bgc::inetstack::tcp::established::background;tcp::established::background::receiver;catnip::runtime::transmit 21.14 616.63 264.17 5.23
bgc::inetstack::tcp::passiveopen::background;catnip::runtime::transmit 20.93 16056.73 7149.16 26.37
demikernel::connect 20.93 3914.88 1717.88 0.00
bgc::inetstack::tcp::established::background;tcp::established::background::sender;catnip::runtime::transmit 20.93 628.56 272.07 10.78
demikernel::socket 10.30 2200.41 966.27 0.00
bgc::inetstack::tcp::established::background;tcp::established::background::acknowledger;catnip::runtime::transmit 9.00 3843.78 1593.96 40.45
bgc::inetstack::arp::background 6.43 2286.59 996.11 0.00
bgc::inetstack::poll_recv;inetstack::poll;inetstack::layer4_endpoint::poll_once 2.00 20149.53 8757.87 95.18
bgc::inetstack::poll_recv;inetstack::poll;inetstack::layer4_endpoint::poll_once;catnip::runtime::receive 2.00 18037.17 7840.00 89.51
bgc::inetstack::icmp::background 1.05 2977.60 1296.90 0.00
demikernel::new 1.00 1762364671.90 765175087.92 47.69
bgc::inetstack::poll_recv;inetstack::poll 1.00 42332.10 18400.27 0.13
demikernel::bind 1.00 11571.38 5114.99 0.00
demikernel::listen 1.00 9262.71 4033.45 0.00
demikernel::close 0.00 nan nan 0.00

@anandbonde anandbonde merged commit 5017253 into dev Nov 14, 2024
14 checks passed
@anandbonde anandbonde deleted the enhancement-log-full branch November 14, 2024 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants