Adding Warnings As Errors for release builds (#361)

* Setting TreatWarningsAsErrors in release build * Fixing warning by unifying S.R.Metadata versions
microsoft · Oct 14, 2016 · 7686067 · 7686067
1 parent 5b8fc64
commit 7686067
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 1 deletion.
diff --git a/dir.props b/dir.props
@@ -14,4 +14,10 @@
     <SignAssembly>true</SignAssembly>
     <AssemblyOriginatorKeyFile>$(MSBuildThisFileDirectory)\PortabilityTools.snk</AssemblyOriginatorKeyFile>
   </PropertyGroup>
+  <!-- Trying to mitigate the number of warnings that the solution contains by
+    adding this into our Release builds.  As a result, it should be caught in
+    our PRs because of the CI builds -->
+  <PropertyGroup Condition=" '$(Configuration)' == 'Release' ">
+    <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
+  </PropertyGroup>
 </Project>
diff --git a/tests/Microsoft.Fx.Portability.Cci.Tests/app.config b/tests/Microsoft.Fx.Portability.Cci.Tests/app.config
@@ -14,6 +14,10 @@
         <assemblyIdentity name="System.Collections.NonGeneric" publicKeyToken="b03f5f7f11d50a3a" culture="neutral" />
         <bindingRedirect oldVersion="0.0.0.0-4.0.1.0" newVersion="4.0.1.0" />
       </dependentAssembly>
+      <dependentAssembly>
+        <assemblyIdentity name="System.Reflection.Metadata" publicKeyToken="b03f5f7f11d50a3a" culture="neutral" />
+        <bindingRedirect oldVersion="0.0.0.0-1.4.1.0" newVersion="1.4.1.0" />
+      </dependentAssembly>
       <dependentAssembly>
         <assemblyIdentity name="System.IO.FileSystem.Primitives" publicKeyToken="b03f5f7f11d50a3a" culture="neutral" />
         <bindingRedirect oldVersion="0.0.0.0-4.0.1.0" newVersion="4.0.1.0" />

diff --git a/tests/Microsoft.Fx.Portability.Cci.Tests/project.json b/tests/Microsoft.Fx.Portability.Cci.Tests/project.json
@@ -1,9 +1,9 @@
 {
   "dependencies": {
     "Microsoft.CodeAnalysis.CSharp": "1.3.2",
-    "System.Reflection.Metadata": "1.2.0",
     "Newtonsoft.Json": "9.0.1",
     "NSubstitute": "1.10.0",
+    "System.Reflection.Metadata": "1.4.1-beta-24227-04",
     "xunit": "2.1.0",
     "xunit.runner.visualstudio": "2.1.0"
   },