Skip to content

Commit

Permalink
work on review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
mahajan-xor committed Jun 6, 2024
1 parent 6f8bf1c commit 810cb16
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
// Licensed under the MIT License (MIT). See LICENSE in the repo root for license information.
// -------------------------------------------------------------------------------------------------

using System;
using System.Collections.Generic;
using System.Threading;
using System.Threading.Tasks;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,7 @@
// Copyright (c) Microsoft Corporation. All rights reserved.
// Licensed under the MIT License (MIT). See LICENSE in the repo root for license information.
// -------------------------------------------------------------------------------------------------
using System.Linq;
using System.Text;
using System.Threading.Tasks;

using Microsoft.Azure.Cosmos.Scripts;

namespace Microsoft.Health.Fhir.CosmosDb.Core.Features.Storage.StoredProcedures
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,15 +17,13 @@ public sealed class DataPlaneStoredProcedureInstaller : IStoredProcedureInstalle
{
private readonly IEnumerable<IStoredProcedureMetadata> _storeProceduresMetadata;

// TODO: refactor constructor to have dependency on container
public DataPlaneStoredProcedureInstaller(IEnumerable<IStoredProcedureMetadata> storedProcedures)
{
EnsureArg.IsNotNull(storedProcedures, nameof(storedProcedures));

_storeProceduresMetadata = storedProcedures;
}

// TODO: refactor method to have dependency on IReadOnlyList<Istoredproceduremetada>
public async Task ExecuteAsync(Container container, CancellationToken cancellationToken)
{
foreach (IStoredProcedureMetadata storedProc in _storeProceduresMetadata)
Expand Down

0 comments on commit 810cb16

Please sign in to comment.