Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Do not review] New schema with reference separation #4710

Open
wants to merge 29 commits into
base: main
Choose a base branch
from

change capture

848195c
Select commit
Loading
Failed to load commit list.
Open

[Do not review] New schema with reference separation #4710

change capture
848195c
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / CodeQL completed Nov 19, 2024 in 4s

1 configuration not found

Warning: Code scanning may not have found all the alerts introduced by this pull request, because 1 configuration present on refs/heads/main was not found:

API upload

  • ❓  <default>

New alerts in code changed by this pull request

  • 10 notes

See annotations below for details.

View all branch alerts.

Annotations

Check notice on line 24 in src/Microsoft.Health.Fhir.SqlServer/Features/Storage/SqlAdlsStore.cs

See this annotation in the file changed.

Code scanning / CodeQL

Missed 'readonly' opportunity Note

Field '_adlsAccountManagedIdentityClientId' can be 'readonly'.

Check notice on line 25 in src/Microsoft.Health.Fhir.SqlServer/Features/Storage/SqlAdlsStore.cs

See this annotation in the file changed.

Code scanning / CodeQL

Missed 'readonly' opportunity Note

Field '_adlsClient' can be 'readonly'.

Check notice on line 26 in src/Microsoft.Health.Fhir.SqlServer/Features/Storage/SqlAdlsStore.cs

See this annotation in the file changed.

Code scanning / CodeQL

Missed 'readonly' opportunity Note

Field '_adlsIsSet' can be 'readonly'.

Check notice on line 38 in src/Microsoft.Health.Fhir.SqlServer/Features/Storage/SqlAdlsStore.cs

See this annotation in the file changed.

Code scanning / CodeQL

Static field written by instance method Note

Write to static field from instance method, property, or constructor.

Check notice on line 39 in src/Microsoft.Health.Fhir.SqlServer/Features/Storage/SqlAdlsStore.cs

See this annotation in the file changed.

Code scanning / CodeQL

Static field written by instance method Note

Write to static field from instance method, property, or constructor.

Check notice on line 42 in src/Microsoft.Health.Fhir.SqlServer/Features/Storage/SqlAdlsStore.cs

See this annotation in the file changed.

Code scanning / CodeQL

Static field written by instance method Note

Write to static field from instance method, property, or constructor.

Check notice on line 43 in src/Microsoft.Health.Fhir.SqlServer/Features/Storage/SqlAdlsStore.cs

See this annotation in the file changed.

Code scanning / CodeQL

Static field written by instance method Note

Write to static field from instance method, property, or constructor.

Check notice on line 47 in src/Microsoft.Health.Fhir.SqlServer/Features/Storage/SqlAdlsStore.cs

See this annotation in the file changed.

Code scanning / CodeQL

Static field written by instance method Note

Write to static field from instance method, property, or constructor.

Check notice on line 52 in src/Microsoft.Health.Fhir.SqlServer/Features/Storage/SqlAdlsStore.cs

See this annotation in the file changed.

Code scanning / CodeQL

Static field written by instance method Note

Write to static field from instance method, property, or constructor.

Check notice on line 53 in src/Microsoft.Health.Fhir.SqlServer/Features/Storage/SqlAdlsStore.cs

See this annotation in the file changed.

Code scanning / CodeQL

Static field written by instance method Note

Write to static field from instance method, property, or constructor.