Fix combobox GetOptionValue #3739
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ All tests passed successfully Details on your Workflow / Core Tests page. |
Summary - Unit Tests Code CoverageSummary
CoverageMicrosoft.FluentUI.AspNetCore.Components - 59.6%
|
|
Are we sure this returns the correct value for a Combobox in the case of editing in the text box part (ie when not selecting an item from the list of options). I recall we had issues there before. |
Good question. I will check this case. |
@vnbaaij You're right. I updated the code to display the before
after
I used this code to validate: <FluentCombobox Items=@stringOptions
OptionText="@(i => i.Text)"
OptionValue="@(i => i.Value.ToString())"
@bind-Value="@stringValue"
@bind-SelectedOption="selectedOption" />
<div>
Selected Value: @stringValue
</div>
<div>
Selected Option Text: @selectedOption?.Text
</div>
<div>
Selected Option Value: @selectedOption?.Value
</div>
@code {
string? stringValue;
Option<int>? selectedOption;
List<Option<int>> stringOptions = new()
{
{ new Option<int> { Value = 1, Text = "One" } },
{ new Option<int> { Value = 2, Text = "Two"} },
{ new Option<int> { Value = 3, Text = "Three" } }
};
}Can you double check before to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix combobox GetOptionValue
The correct
GetOptionValueis already included in theListComponentBaseclass.#3734