docs(react-table): Adding stop propagation to focusable elements in DataGrid so that clicking on them does not toggle cell selection
#33262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on them does not toggle cell selection.
📊 Bundle size report✅ No changes found |
|
Pull request demo site: URL |
ling1726
added a commit
to ling1726/fluentui
that referenced
this pull request
Nov 20, 2024
Adds stopPropagation to button and button groups in cells to avoid triggering row selection. Fixes microsoft#33262
|
Superseded by #33307 |
khmakoto
deleted the
docs/react-table/dataGridFocusableElementsStopPropagation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
Buttons in the
DataGridfocusable elements example were toggling cell selection. The correct thing to show in our docs is probably to have them not toggle this selection.New Behavior
Buttons in the
DataGridfocusable elements example now stop propagation to avoid toggling cell selection and a mention of this has been made in the example description.Related Issue(s)