Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Text Inside Donut chart fix #33309

Draft
wants to merge 3 commits into
base: charting/web-components
Choose a base branch
from
Draft

Text Inside Donut chart fix #33309

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a22b5ec
update inside donut chart fix
Anush2303 Nov 21, 2024
60f06bc
api-report.md updated
Anush2303 Nov 21, 2024
565eeca
Merge branch 'charting/web-components' into usr/agupta/webc/donutchar…
Anush2303 Nov 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions packages/charts/chart-web-components/docs/api-report.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ export class DonutChart extends FASTElement {
// (undocumented)
activeLegend: string;
// (undocumented)
activeLegendChanged: (oldValue: string, newValue: string) => void;
activeLegendChanged(oldValue: string, newValue: string): void;
// (undocumented)
chartWrapper: HTMLDivElement;
// (undocumented)
Expand All @@ -28,17 +28,17 @@ export class DonutChart extends FASTElement {
// (undocumented)
data: ChartProps_2;
// (undocumented)
elementInternals: ElementInternals;
getLegends(): Legend[];
// (undocumented)
getLegends: () => Legend[];
elementInternals: ElementInternals;
// (undocumented)
group: SVGGElement;
// (undocumented)
handleLegendClick: (legendTitle: string) => void;
handleLegendClick(legendTitle: string): void;
// (undocumented)
handleLegendMouseoutAndBlur: () => void;
handleLegendMouseoutAndBlur(): void;
// (undocumented)
handleLegendMouseoverAndFocus: (legendTitle: string) => void;
handleLegendMouseoverAndFocus(legendTitle: string): void;
// (undocumented)
height: number;
// (undocumented)
Expand Down Expand Up @@ -67,6 +67,8 @@ export class DonutChart extends FASTElement {
yPos: number;
};
// (undocumented)
tooltipPropsChanged(oldValue: any, newValue: any): void;
// (undocumented)
valueInsideDonut?: string;
// (undocumented)
width: number;
Expand Down
2 changes: 0 additions & 2 deletions packages/charts/chart-web-components/src/donut-chart/donut-chart.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,10 +220,8 @@ export class DonutChart extends FASTElement {
}
});
}

this._updateTextInsideDonut();
}

private _getTextInsideDonut(valueInsideDonut: string) {
let textInsideDonut = valueInsideDonut;

Expand Down
Loading