Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Accept Credential in AzureAISearchVectorStore #1695

Open
3 tasks done
joerattazzi-microsoft opened this issue Feb 11, 2025 · 0 comments
Open
3 tasks done
Labels
enhancement New feature or request

Comments

@joerattazzi-microsoft
Copy link

Do you need to file an issue?

  • I have searched the existing issues and this feature is not already filed.
  • My model is hosted on OpenAI or Azure. If not, please look at the "model providers" issue and don't file a new one here.
  • I believe this is a legitimate feature request, not just a question. If this is a question, please use the Discussions area.

Is your feature request related to a problem? Please describe.

AzureAISearchVectorStore assumes that you're either able to provide an api_key or that the DefaultAzureCredential will work as a fallback.

When operating in a system where DefaultAzureCredential won't work as needed (such as via Azure Synapse), api_key isn't always an option due to security concerns.

Under the covers, AzureAISearchVectorStore uses these to create a Credential to use. I'm proposing an option to provide a credential directly when leveraging AzureAISearchVectorStore as a new input.

Describe the solution you'd like

A new kwargs entry is added for credential such that it can optionally be provided. It would be added in a non-breaking manner such that the order of preference for a Credential to use internally does not break active users:

  1. the api_key
  2. the provided credential input (new)
  3. Fall back to the DefaultAzureCredential

Additional context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant