Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to provide a custom credential in AzureAISearchVectorStore #1782

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

joerattazzi-microsoft
Copy link

Description

My team is using GraphRAG's AzureAISearchVectorStore class. Where we're using this, we need the ability to provide a credential directly, as we can't set api_key and DefaultAzureCredential doesn't meet our needs.

By default, AzureAISearchVectorStore class will:

  • check for an api_key to be set
  • if no api_key is provided, default to DefaultAzureCredential

Our proposed change will add the support in this way:

  • check for an api_key to be set
  • if no api_key is provided, use a provided credential if one is given.
  • if no other input is provided, default to DefaultAzureCredential

Related Issues

#1695

Proposed Changes

Our proposed change will add the support in this way:

  • check for an api_key to be set
  • if no api_key is provided, use a provided credential if one is given.
  • if no other input is provided, default to DefaultAzureCredential

Checklist

  • I have tested these changes locally.
  • I have reviewed the code changes.
  • I have updated the documentation (if necessary).
  • I have added appropriate unit tests (if applicable).

Additional Notes

This probably won't solve use cases through the API, but it should enable future expansion if needed

@joerattazzi-microsoft joerattazzi-microsoft requested review from a team as code owners March 3, 2025 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant