Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task: Support ttk add plugin #5759

Merged
merged 15 commits into from
Nov 18, 2024
Merged

Task: Support ttk add plugin #5759

merged 15 commits into from
Nov 18, 2024

Conversation

thewahome
Copy link
Contributor

@thewahome thewahome commented Nov 12, 2024 •
edited
Loading

Overview

Closes #5751

Notes

  • if the provided path does not exist, it is created. If that doesn't work, the temporary folder is used.

@thewahome thewahome requested a review from a team as a code owner November 12, 2024 10:22
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 12, 2024

Quality Gate Passed Quality Gate passed for 'microsoft_kiota_frontend'

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
52.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

samwelkanda
samwelkanda previously approved these changes Nov 18, 2024
View reviewed changes
calebkiage
calebkiage reviewed Nov 18, 2024
View reviewed changes
Copy link
Contributor

@calebkiage calebkiage left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have left some improvement comments on the PR. Let me know what you think or if you need more information. Also, is it possible to test the new logic? I could see a future refactor inadvertently breaking this flow.

Also, take a look at the sonarcloud issue that has been highlighted

vscode/microsoft-kiota/src/utilities/deep-linking.ts Show resolved Hide resolved
vscode/microsoft-kiota/src/utilities/deep-linking.ts Outdated Show resolved Hide resolved
@thewahome thewahome merged commit e2a2550 into main Nov 18, 2024
209 of 210 checks passed
@thewahome thewahome deleted the task/extension/support-ttk-add-plugin branch November 18, 2024 08:38
@thewahome
Copy link
Contributor Author

@calebkiage the sonarcloud issue had been previously resolved but it didn't refresh.
I've seen and actioned the other comments. I will add tests as a separate issue. It made sense to me at the that the tests were still passing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calebkiage calebkiage calebkiage left review comments

@SilasKenneth SilasKenneth SilasKenneth approved these changes

@koros koros koros approved these changes

@samwelkanda samwelkanda samwelkanda left review comments

Assignees
No one assigned
Labels
None yet
Projects
Kiota
Status: Done ✔️
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Add plugin flow coming from TTK
5 participants
@thewahome @calebkiage @koros @SilasKenneth @samwelkanda