Add device-passthrough testcase for CH platform #3415
Conversation
smit-gardhariya
requested review from
squirrelsc and
LiliDeng
as code owners
| } | ||
| pool_vendor_device_map[pool_type] = vendor_device_id | ||
|
|
||
| assert environment.runbook.nodes_requirement, "requirement cant be empty" |
There was a problem hiding this comment.
I'm not understand the logic, why does it need to check platform runbook and node runbook both? They should be expected values, and one of them should be enough to provide the expected value.
There was a problem hiding this comment.
Device pool is part of platform runbook whereas what kind of device need to be assigned from pool is part of node runbook.
Platform runbook defines the pool configuration
Node runbook defines how many devices/what kind of devices need to be passthrough under requirement section
There was a problem hiding this comment.
Here is the reference @squirrelsc
platform:
-type: cloud-hypervisor
cloud-hypervisor:
device_pools:
- type: "pci_net"
devices:
- vendor_id: xxx
device_id: xxx
requirement:
cloud-hypervisor:
device_passthrough:
-pool_type: "pci_net"
managed: "yes"
count: 1
There was a problem hiding this comment.
Use node.runbook, instead of nodes_requirement. The nodes_requirements may be expanded to multiple nodes.
There was a problem hiding this comment.
We are using extended runbook only. Let me check if is there other better way to get the runbook.
There was a problem hiding this comment.
Using extended runbook only to get the expected value.
There was a problem hiding this comment.
Please check Azure platform code. the runbook should be merged, and copied to each node. The nodes_requirement is the raw info to create nodes, which shouldn't be used for each environment.
lisa/lisa/sut_orchestrator/azure/platform_.py
Line 1123 in d50a39f
smit-gardhariya
force-pushed
the
sgardhariya/verify_device_passthrough
branch
from
4504c04
to
0d77e02
Compare
Add test case to verify if passthrough-devices are visible to guest for CH platform Signed-off-by: Smit Gardhariya <[email protected]>
smit-gardhariya
force-pushed
the
sgardhariya/verify_device_passthrough
branch
from
0d77e02
to
d50a39f
Compare
| BaseLibvirtNodeSchema, CLOUD_HYPERVISOR | ||
| ) | ||
| if not node_runbook.device_passthrough: | ||
| raise SkippedException("No device-passthrough is set for node") |
There was a problem hiding this comment.
This check should happen earlier before any other command.
Add test case to verify if passthrough-devices
are visible to guest for CH platform