-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stabilize MPI tests for Azure Linux #3521
base: main
Are you sure you want to change the base?
Conversation
@cyberbandya007 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
@@ -286,6 +286,9 @@ def verify_intel_mpi(self, environment: Environment, log: Logger) -> None: | |||
client_ssh.enable_public_key(server_ssh.generate_key_pairs()) | |||
server_ssh.add_known_host(client_ip) | |||
client_ssh.add_known_host(server_ip) | |||
sudo=False | |||
if isinstance(server_node.os, CBLMariner): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add comments above to explain why Mariner needs sudo.
server_node.execute("ldconfig", sudo=True) | ||
client_node.execute("ldconfig", sudo=True) | ||
|
||
# Only for mariner, we need to build intel benchmarking tools | ||
# as they are not included in our packages | ||
server_ib.install_intel_mpi_benchmarking_tool() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also add if
block here to skip other distros. So the logic here is easier to know at the test case level. The if
block in the install_intel_mpi_benchmarking_tool
is a safe guard.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure.
@@ -571,6 +580,12 @@ def verify_mvapich_mpi(self, environment: Environment, log: Logger) -> None: | |||
raise SkippedException(err) | |||
|
|||
run_in_parallel([server_ib.install_mvapich_mpi, client_ib.install_mvapich_mpi]) | |||
test_names = ["IMB-MPI1", "IMB-RMA", "IMB-NBC"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add if
block for Mariner.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is moved from line no 596 to reuse for mariner. I will add if block after this as this is required for other tests also.
No description provided.